Add dependencies to type variables used in the super type declaration, but do

Add dependencies to type variables used in the super type declaration, but do
not do so recursively (the enclosing fuction is supposed to only record direct,
and not recursive dependencies).

R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/cf43d4603c88f1c055f92a634deb1d6ba30fa4fc

[Siggi Cherem (dart-lang), 2017-08-11 21:34:00]

sigmund@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-08-11 21:55:47]

lgtm

https://codereview.chromium.org/3000843002/diff/1/pkg/compiler/lib/src/deferr...
File pkg/compiler/lib/src/deferred_load.dart (right):

https://codereview.chromium.org/3000843002/diff/1/pkg/compiler/lib/src/deferr...
pkg/compiler/lib/src/deferred_load.dart:464:
elements.add(type.element.implementation);
I think we need types from all supertypes to ensure they are available for the
$asX functions.

[Siggi Cherem (dart-lang), 2017-08-11 22:06:56]

Patchset #2 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2017-08-11 22:08:15]

thanks

https://codereview.chromium.org/3000843002/diff/1/pkg/compiler/lib/src/deferr...
File pkg/compiler/lib/src/deferred_load.dart (right):

https://codereview.chromium.org/3000843002/diff/1/pkg/compiler/lib/src/deferr...
pkg/compiler/lib/src/deferred_load.dart:464:
elements.add(type.element.implementation);
On 2017/08/11 21:55:46, sra1 wrote:
> I think we need types from all supertypes to ensure they are available for the
> $asX functions.

Done. Also added a test with an `is` check. We should be good now.

[Siggi Cherem (dart-lang), 2017-08-11 22:09:26]

Patchset #2 (id:40001) has been deleted

[Siggi Cherem (dart-lang), 2017-08-11 22:11:29]

Description was changed from

==========
Add dependencies to type variables used in the super type declaration, but do
not do so recursively (the enclosing fuction is supposed to only record direct,
and not recursive dependencies).
==========

to

==========
Add dependencies to type variables used in the super type declaration, but do
not do so recursively (the enclosing fuction is supposed to only record direct,
and not recursive dependencies).

R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cf43d4603c88f1c055f92a634deb1d6ba30fa4fc
==========

[Siggi Cherem (dart-lang), 2017-08-11 22:11:31]

Committed patchset #2 (id:60001) manually as
cf43d4603c88f1c055f92a634deb1d6ba30fa4fc (presubmit successful).