Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Unified Diff: pkg/compiler/lib/src/deferred_load.dart

Issue 3000843002: Add dependencies to type variables used in the super type declaration, but do (Closed)
Patch Set: v2 Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js_extra/dart2js_extra.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/deferred_load.dart
diff --git a/pkg/compiler/lib/src/deferred_load.dart b/pkg/compiler/lib/src/deferred_load.dart
index fe9a4731edb41b6c4a3165dc2a876a4fb0ccfd1d..ceca9001e72c5ad471d7b4ff710637540e7ff461 100644
--- a/pkg/compiler/lib/src/deferred_load.dart
+++ b/pkg/compiler/lib/src/deferred_load.dart
@@ -319,9 +319,7 @@ class DeferredLoadTask extends CompilerTask {
elements.add(type.element);
collectTypeDependencies(type.unaliased);
} else if (type is ResolutionInterfaceType) {
- if (elements.add(type.element)) {
- collectTypeDependencies(type.element.supertype);
- }
+ elements.add(type.element);
}
}
@@ -458,7 +456,7 @@ class DeferredLoadTask extends CompilerTask {
ClassElement cls = element.declaration;
cls.implementation.forEachMember(addLiveInstanceMember);
for (ResolutionInterfaceType type in cls.implementation.allSupertypes) {
- elements.add(type.element.implementation);
+ collectTypeDependencies(type);
}
elements.add(cls.implementation);
} else if (Elements.isStaticOrTopLevel(element) || element.isConstructor) {
« no previous file with comments | « no previous file | tests/compiler/dart2js_extra/dart2js_extra.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698