Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 3000433002: Changed cast from uint32_t to size_t to work on 64 bit. (Closed)

Created:
3 years, 4 months ago by njanevsk
Modified:
3 years, 4 months ago
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

Changed cast from uint32_t to size_t to work on 64 bit. BUG= Review-Url: https://codereview.chromium.org/3000433002 Committed: https://github.com/google/syzygy/commit/df57cbafe7444b4f296e4218c2450dffe0f70ad4

Patch Set 1 #

Patch Set 2 : Changed cast from uint32_t to size_t to work on 64 bit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M syzygy/trace/parse/parse_engine.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
njanevsk
PTAL!
3 years, 4 months ago (2017-08-07 23:48:53 UTC) #5
Sébastien Marchand
lgtm
3 years, 4 months ago (2017-08-08 14:10:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3000433002/20001
3 years, 4 months ago (2017-08-08 14:10:34 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-08 14:10:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/google/syzygy/commit/df57cbafe7444b4f296e4218c2450dffe0f70ad4

Powered by Google App Engine
This is Rietveld 408576698