[Telemetry] Rename PermanentlyDisableBenchmark to DisableBenchmark.

[Telemetry] Rename PermanentlyDisableBenchmark to DisableBenchmark.

Benchmarks now have a variable (SUPPORTED_PLATFORMS) that is used to
determine if a benchmark should run on a given platform. DisableBenchmark
will be used in cases where we want to disable the benchmark, but want
it to be clear that its disabled because it is failing not becuase it is
not intended to run on that platform.

TBR=nednguyen@google.com
BUG=chromium:713222
Review-Url: https://codereview.chromium.org/3000413002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/be203293da087dc9a943f922ab34a14cef05aee6

[rnephew (Reviews Here), 2017-08-23 20:20:28]

rnephew@chromium.org changed reviewers:
+ charliea@chromium.org, nednguyen@google.com, perezju@chromium.org

[charliea (OOO until 10-5), 2017-08-24 21:04:25]

lgtm

https://codereview.chromium.org/3000413002/diff/1/telemetry/telemetry/story/e...
File telemetry/telemetry/story/expectations.py (right):

https://codereview.chromium.org/3000413002/diff/1/telemetry/telemetry/story/e...
telemetry/telemetry/story/expectations.py:51: """Permanently Disable benchmark
under the given conditions.
Probably want to strike the word "Permanently" here, and possibly even add
comment text to suggest that this should be used for temporary disables.

[rnephew (Reviews Here), 2017-08-24 21:57:00]

https://codereview.chromium.org/3000413002/diff/1/telemetry/telemetry/story/e...
File telemetry/telemetry/story/expectations.py (right):

https://codereview.chromium.org/3000413002/diff/1/telemetry/telemetry/story/e...
telemetry/telemetry/story/expectations.py:51: """Permanently Disable benchmark
under the given conditions.
On 2017/08/24 21:04:24, charliea wrote:
> Probably want to strike the word "Permanently" here, and possibly even add
> comment text to suggest that this should be used for temporary disables.

Done.

[rnephew (Reviews Here), 2017-08-24 21:57:03]

The CQ bit was checked by rnephew@chromium.org

[rnephew (Reviews Here), 2017-08-24 21:57:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
charliea@chromium.org
Link to the patchset: https://codereview.chromium.org/3000413002/#ps20001
(title: "change comments")

[commit-bot: I haz the power, 2017-08-24 21:57:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-24 22:01:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-24 22:01:09]

Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[rnephew (Reviews Here), 2017-08-24 22:09:31]

Description was changed from

==========
[Telemetry] Rename PermanentlyDisableBenchmark to DisableBenchmark.

Benchmarks now have a variable (SUPPORTED_PLATFORMS) that is used to
determine if a benchmark should run on a given platform. DisableBenchmark
will be used in cases where we want to disable the benchmark, but want
it to be clear that its disabled because it is failing not becuase it is
not intended to run on that platform.

BUG=chromium:713222
==========

to

==========
[Telemetry] Rename PermanentlyDisableBenchmark to DisableBenchmark.

Benchmarks now have a variable (SUPPORTED_PLATFORMS) that is used to
determine if a benchmark should run on a given platform. DisableBenchmark
will be used in cases where we want to disable the benchmark, but want
it to be clear that its disabled because it is failing not becuase it is
not intended to run on that platform.

TBR=nednguyen@google.com
BUG=chromium:713222
==========

[rnephew (Reviews Here), 2017-08-24 22:09:35]

The CQ bit was checked by rnephew@chromium.org

[commit-bot: I haz the power, 2017-08-24 22:09:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-24 22:52:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1503612575438660,
"parent_rev": "e37aa9d6016b3a6fec594409dd651029d7201099", "commit_rev":
"be203293da087dc9a943f922ab34a14cef05aee6"}

[commit-bot: I haz the power, 2017-08-24 22:52:37]

Description was changed from

==========
[Telemetry] Rename PermanentlyDisableBenchmark to DisableBenchmark.

Benchmarks now have a variable (SUPPORTED_PLATFORMS) that is used to
determine if a benchmark should run on a given platform. DisableBenchmark
will be used in cases where we want to disable the benchmark, but want
it to be clear that its disabled because it is failing not becuase it is
not intended to run on that platform.

TBR=nednguyen@google.com
BUG=chromium:713222
==========

to

==========
[Telemetry] Rename PermanentlyDisableBenchmark to DisableBenchmark.

Benchmarks now have a variable (SUPPORTED_PLATFORMS) that is used to
determine if a benchmark should run on a given platform. DisableBenchmark
will be used in cases where we want to disable the benchmark, but want
it to be clear that its disabled because it is failing not becuase it is
not intended to run on that platform.

TBR=nednguyen@google.com
BUG=chromium:713222

Review-Url: https://codereview.chromium.org/3000413002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-08-24 22:52:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...