Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3000123002: dart2js kernel: minimal recognition of external native methods (Closed)

Created:
3 years, 4 months ago by sra1
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js kernel: minimal recognition of external native methods TBR=sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8499c8f12edb2d544596069e02cb1c89c11e3df3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -85 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 3 chunks +20 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 2 chunks +62 lines, -66 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 3 chunks +3 lines, -6 lines 2 comments Download
M tests/language/language_dart2js.status View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/language_2/language_2_dart2js.status View 4 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
Committed patchset #1 (id:20001) manually as 8499c8f12edb2d544596069e02cb1c89c11e3df3 (presubmit successful).
3 years, 4 months ago (2017-08-18 04:39:29 UTC) #5
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/3000123002/diff/20001/tests/corelib_2/corelib_2.status File tests/corelib_2/corelib_2.status (right): https://codereview.chromium.org/3000123002/diff/20001/tests/corelib_2/corelib_2.status#newcode486 tests/corelib_2/corelib_2.status:486: date_time_test: Timeout let's mark this differently then: : ...
3 years, 4 months ago (2017-08-18 16:29:08 UTC) #6
sra1
3 years, 4 months ago (2017-08-18 17:05:20 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/3000123002/diff/20001/tests/corelib_2/corelib...
File tests/corelib_2/corelib_2.status (right):

https://codereview.chromium.org/3000123002/diff/20001/tests/corelib_2/corelib...
tests/corelib_2/corelib_2.status:486: date_time_test: Timeout
On 2017/08/18 16:29:08, Siggi Cherem (dart-lang) wrote:
> let's mark this differently then:
> 
> : Skip # TODO(redemption): times out

Dove via https://codereview.chromium.org/3000213002/

Powered by Google App Engine
This is Rietveld 408576698