Migrated test block 168 to Dart 2.0.

tests/lib_2/lib_2.status

Index: tests/lib_2/lib_2.status
diff --git a/tests/lib_2/lib_2.status b/tests/lib_2/lib_2.status
index 8ed3c7d6556c23f5e3b60dfadec572575953480c..e8e362d4e9229980b9e2f151619579d5315b5cc2 100644
--- a/tests/lib_2/lib_2.status
+++ b/tests/lib_2/lib_2.status
@@ -1,3 +1,20 @@
 # Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
+
+[ $strong && $compiler != dart2analyzer && $compiler != dartdevc ]

[Bob Nystrom, 2017/08/16 22:27:20]

Is this basically to match "strong mode on the VM"? If so, it would be good make
that more explicit. Maybe "$runtime == vm" and move it into that status file?

[bkonyi, 2017/08/16 23:44:13]

Done.

+# async/future_or_bad_type_test/implements: CompileTimeError

[Bob Nystrom, 2017/08/16 22:27:20]

Should this be commented out?

[bkonyi, 2017/08/16 23:44:13]

This was temporary since adding that line actually caused failures (this was one
of the tests I was having issues with). I've since fixed this.

+async/future_or_only_in_async_test/00: MissingCompileTimeError
+
+[ !$strong && $compiler != dartdevc && $checked ]
+async/future_or_bad_type_test/implements: CompileTimeError
+async/future_or_only_in_async_test/00: MissingCompileTimeError
+
+[ !$strong && !$checked]
+async/future_or_bad_type_test/implements: CompileTimeError
+async/future_or_only_in_async_test/00: MissingCompileTimeError
+
+[ $compiler != dart2js ]
+async/dart2js_uncaught_error_test: Skip  # JS-integration only test

[Bob Nystrom, 2017/08/16 22:27:20]

Ah, the migration script doesn't handle "!=" (because it's not always clear what
those mean). In this case, it's a dart2js-related test, so I would move this to
lib_dart2js.status.

Even better would be to move it out of lib_2/ entirely into compiler/dart2js,
but that's more of a pain. Maybe add a TODO in the test to do that?

[bkonyi, 2017/08/16 23:44:13]

Added the TODO. Done.

+
+