Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: tests/lib_2/async/future_value_chain4_test.dart

Issue 2999943002: Migrated test block 168 to Dart 2.0. (Closed)
Patch Set: Fixed async/future_test.dart Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/lib_2/async/future_value_chain4_test.dart
diff --git a/tests/lib_strong/async/future_value_chain4_test.dart b/tests/lib_2/async/future_value_chain4_test.dart
similarity index 86%
rename from tests/lib_strong/async/future_value_chain4_test.dart
rename to tests/lib_2/async/future_value_chain4_test.dart
index 38952e9c33ab2c218073bc1cbaef467b9f7991ae..f9940a53767dcf80b387d90ee9230ea6adddcba1 100644
--- a/tests/lib_strong/async/future_value_chain4_test.dart
+++ b/tests/lib_2/async/future_value_chain4_test.dart
@@ -6,11 +6,12 @@ import 'package:async_helper/async_helper.dart';
import "package:expect/expect.dart";
import 'dart:async';
-class MyFuture implements Future {
- then(valueHandler, {onError}) {
+class MyFuture<T> implements Future<T> {
+ Future<S> then<S>(dynamic valueHandler(T), {Function onError}) {
Bob Nystrom 2017/08/16 22:27:20 "dynamic" -> "S"?
bkonyi 2017/08/16 23:44:13 dynamic -> FutureOr<S> is correct. Done.
scheduleMicrotask(() {
valueHandler(499);
});
+ return null;
}
catchError(_, {test}) => null;

Powered by Google App Engine
This is Rietveld 408576698