Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2999933002: Revert "Add current rss and embedder name to Observatory" (Closed)

Created:
3 years, 4 months ago by cbernaschina
Modified:
3 years, 4 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, turnidge, rmacnak, zra, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add current rss and embedder name to Observatory" This reverts commit ce736d3ef009bf334a92d5b7d354fc0b04805b4f. TBR=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/2f5a59e658cfa867a74e9d2672058463b422fcde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -331 lines) Patch
M runtime/bin/main.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M runtime/bin/process_android.cc View 1 chunk +10 lines, -12 lines 0 comments Download
M runtime/bin/process_linux.cc View 1 chunk +10 lines, -12 lines 0 comments Download
M runtime/include/dart_tools_api.h View 1 chunk +0 lines, -43 lines 0 comments Download
M runtime/observatory/lib/models.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/memory/dashboard.dart View 4 chunks +4 lines, -9 lines 0 comments Download
M runtime/observatory/lib/src/elements/memory/graph.dart View 11 chunks +34 lines, -60 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.dart View 7 chunks +5 lines, -42 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/vm.dart View 2 chunks +0 lines, -3 lines 0 comments Download
D runtime/observatory/lib/src/models/repositories/vm.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D runtime/observatory/lib/src/repositories/vm.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/vm.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/vm_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/benchmark_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M runtime/vm/metrics.h View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/metrics.cc View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/vm/os.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/os_android.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/os_linux.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/os_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/service.h View 4 chunks +0 lines, -9 lines 0 comments Download
M runtime/vm/service.cc View 4 chunks +1 line, -59 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
cbernaschina
Committed patchset #1 (id:1) manually as 2f5a59e658cfa867a74e9d2672058463b422fcde.
3 years, 4 months ago (2017-08-14 22:45:28 UTC) #2
zra
3 years, 4 months ago (2017-08-14 22:46:22 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698