Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 2999933002: Revert "Add current rss and embedder name to Observatory" (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/repositories/vm.dart ('k') | runtime/observatory/observatory_sources.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index ef9499cd4cf68d8b33a14e5ebf7ce4d2c65ec7ef..7d238edac02f7fe3d65f6ac755da4d3d3b727289 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -669,7 +669,6 @@ abstract class VM extends ServiceObjectOwner implements M.VM {
String version = 'unknown';
String hostCPU;
String targetCPU;
- String embedder;
int architectureBits;
bool assertsEnabled = false;
bool typeChecksEnabled = false;
@@ -677,8 +676,7 @@ abstract class VM extends ServiceObjectOwner implements M.VM {
int pid = 0;
int heapAllocatedMemoryUsage = 0;
int heapAllocationCount = 0;
- int maxRSS;
- int currentRSS;
+ int maxRSS = 0;
bool profileVM = false;
DateTime startTime;
DateTime refreshTime;
@@ -980,11 +978,13 @@ abstract class VM extends ServiceObjectOwner implements M.VM {
nativeZoneMemoryUsage = map['_nativeZoneMemoryUsage'];
}
pid = map['pid'];
- heapAllocatedMemoryUsage = map['_heapAllocatedMemoryUsage'];
- heapAllocationCount = map['_heapAllocationCount'];
- embedder = map['_embedder'];
+ if (map['_heapAllocatedMemoryUsage'] != null) {
+ heapAllocatedMemoryUsage = map['_heapAllocatedMemoryUsage'];
+ }
+ if (map['_heapAllocationCount'] != null) {
+ heapAllocationCount = map['_heapAllocationCount'];
+ }
maxRSS = map['_maxRSS'];
- currentRSS = map['_currentRSS'];
profileVM = map['_profilerMode'] == 'VM';
assertsEnabled = map['_assertsEnabled'];
typeChecksEnabled = map['_typeChecksEnabled'];
« no previous file with comments | « runtime/observatory/lib/src/repositories/vm.dart ('k') | runtime/observatory/observatory_sources.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698