Results.html: record maximum Histogram.numValues in google analytics.

Results.html: record maximum Histogram.numValues in google analytics.

This CL records an instant event 'HistogramParameterCollector.maxSampleCount'
containing the maximum numValues from the raw Histograms that were produced directly
by metrics, before the Histograms are merged.

We know that this number is always 1 for some metrics.
If this number is always 1 across *all* metrics, then we may want to simplify the
metrics API from Histograms to Scalars. In that case, Histograms would still be
necessary as an implementation detail for results.html and the dashboard Histogram
Pipeline, but the metrics API could be simplified.
If this number is not always 1, then it will be easier to explain why the metrics
API requires Histograms instead of the seemingly simpler Scalars.

Review-Url: https://codereview.chromium.org/2999863002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d768f57acb8966c50c10edfe9050c1caa6a2003f

[benjhayden, 2017-08-12 20:25:21]

Description was changed from

==========
Results.html: record maximum Histogram.numValues in google analytics.

If this number is always 1, then we may want to simplify the metrics API from
Histograms to Scalars. In that case, Histograms would still be necessary as an
implementation detail for results.html and the dashboard Histogram Pipeline, but
the metrics api could be simplified.
==========

to

==========
Results.html: record maximum Histogram.numValues in google analytics.

This CL records an instant event 'HistogramParameterCollector.maxSampleCount'
containing the maximum numValues from the raw Histograms that were produced
directly
by metrics, before the Histograms are merged.

We know that this number is always 1 for some metrics.
If this number is always 1 across *all* metrics, then we may want to simplify
the
metrics API from Histograms to Scalars. In that case, Histograms would still be
necessary as an implementation detail for results.html and the dashboard
Histogram
Pipeline, but the metrics API could be simplified.
If this number is not always 1, then it will be easier to explain why the
metrics
API requires Histograms instead of the seemingly simpler Scalars.
==========

[benjhayden, 2017-08-12 20:25:35]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org

[benjhayden, 2017-08-12 20:25:36]

PTAL

[eakuefner, 2017-08-18 23:27:28]

lgtm

How long do we want to evaluate this for? This seems like it could be of great
usability benefit to all metrics authors.

[benjhayden, 2017-08-19 17:09:30]

The CQ bit was checked by benjhayden@chromium.org

[commit-bot: I haz the power, 2017-08-19 17:09:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[benjhayden, 2017-08-19 17:16:31]

On 2017/08/18 at 23:27:28, eakuefner wrote:
> lgtm
> 
> How long do we want to evaluate this for? This seems like it could be of great
usability benefit to all metrics authors.

I expect this number to be large enough often enough that Scalars wouldn't be a
feasible replacement for Histograms, but I'm still interested to see what
exactly it will be, both now and as TBM2 metrics continue to evolve, and I don't
know of any reason to avoid recording too many GA metrics.

[commit-bot: I haz the power, 2017-08-19 17:37:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-19 17:37:04]

Try jobs failed on following builders:
  Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)

[benjhayden, 2017-08-19 17:51:52]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2017-08-19 17:51:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2999863002/#ps20001
(title: "fix vinn tests")

[commit-bot: I haz the power, 2017-08-19 17:52:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-19 18:28:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1503165112854210,
"parent_rev": "21232f747bd10bc9c960bb42f06ed63f7e69d0b0", "commit_rev":
"d768f57acb8966c50c10edfe9050c1caa6a2003f"}

[commit-bot: I haz the power, 2017-08-19 18:28:22]

Description was changed from

==========
Results.html: record maximum Histogram.numValues in google analytics.

This CL records an instant event 'HistogramParameterCollector.maxSampleCount'
containing the maximum numValues from the raw Histograms that were produced
directly
by metrics, before the Histograms are merged.

We know that this number is always 1 for some metrics.
If this number is always 1 across *all* metrics, then we may want to simplify
the
metrics API from Histograms to Scalars. In that case, Histograms would still be
necessary as an implementation detail for results.html and the dashboard
Histogram
Pipeline, but the metrics API could be simplified.
If this number is not always 1, then it will be easier to explain why the
metrics
API requires Histograms instead of the seemingly simpler Scalars.
==========

to

==========
Results.html: record maximum Histogram.numValues in google analytics.

This CL records an instant event 'HistogramParameterCollector.maxSampleCount'
containing the maximum numValues from the raw Histograms that were produced
directly
by metrics, before the Histograms are merged.

We know that this number is always 1 for some metrics.
If this number is always 1 across *all* metrics, then we may want to simplify
the
metrics API from Histograms to Scalars. In that case, Histograms would still be
necessary as an implementation detail for results.html and the dashboard
Histogram
Pipeline, but the metrics API could be simplified.
If this number is not always 1, then it will be easier to explain why the
metrics
API requires Histograms instead of the seemingly simpler Scalars.

Review-Url: https://codereview.chromium.org/2999863002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-08-19 18:28:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...