Issue 2999763002: Clear analyzer warning on Observatory

Issue 2999763002: Clear analyzer warning on Observatory (Closed)

Created:
3 years, 4 months ago by cbernaschina

Modified:
3 years, 4 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, turnidge, rmacnak, zra, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Clear analyzer warning on Observatory - https://github.com/dart-lang/sdk/commit/f8e47a9e26c9ee44f431ed20d4507d98acbc257d Introduced some analyzer warnings into Observatory. - Added missing forward of the forceFetch parameter - Removed two abstraction breaks R=rmacnak@google.com - Applying TODO https://github.com/dart-lang/sdk/blob/ccadb4687c8af4b02a046669b9d50dd52edd1112/runtime/observatory/lib/src/cpu_profile/cpu_profile.dart#L750 Committed: https://github.com/dart-lang/sdk/commit/fb565cfba49f8f387b58ea5e8808e4824fe7ad01

Patch Set 1 #

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -1146 lines)			Patch
D	runtime/observatory/lib/cpu_profile.dart	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	runtime/observatory/lib/repositories.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	runtime/observatory/lib/sample_profile.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/observatory/lib/service.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
D	runtime/observatory/lib/src/cpu_profile/cpu_profile.dart	View	1 chunk	+0 lines, -1090 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/class_allocation_profile.dart	View	4 chunks	+9 lines, -5 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/class_view.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/observatory/lib/src/elements/code_view.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/sample_buffer_control.dart	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/observatory/lib/src/models/objects/vm.dart	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	runtime/observatory/lib/src/models/repositories/sample_profile.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/observatory/lib/src/repositories/sample_profile.dart	View	5 chunks	+10 lines, -6 lines	0 comments	Download
A +	runtime/observatory/lib/src/sample_profile/sample_profile.dart	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	runtime/observatory/lib/src/service/object.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/observatory/observatory_sources.gypi	View	4 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/observatory/tests/observatory_ui/mocks/repositories/sample_profile.dart	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	runtime/observatory/tests/service/get_allocation_samples_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/observatory/tests/service/get_native_allocation_samples_test.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

cbernaschina

3 years, 4 months ago (2017-08-11 19:36:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fb565cfba49f8f387b58ea5e8808e4824fe7ad01 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages