Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: runtime/observatory/lib/src/service/object.dart

Issue 2999763002: Clear analyzer warning on Observatory (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of service; 5 part of service;
6 6
7 // Some value smaller than the object ring, so requesting a large array 7 // Some value smaller than the object ring, so requesting a large array
8 // doesn't result in an expired ref because the elements lapped it in the 8 // doesn't result in an expired ref because the elements lapped it in the
9 // object ring. 9 // object ring.
10 const int kDefaultFieldLimit = 100; 10 const int kDefaultFieldLimit = 100;
(...skipping 423 matching lines...) Expand 10 before | Expand all | Expand 10 after
434 size = map['size']; 434 size = map['size'];
435 } 435 }
436 } 436 }
437 437
438 class RetainingObject implements M.RetainingObject { 438 class RetainingObject implements M.RetainingObject {
439 int get retainedSize => object.retainedSize; 439 int get retainedSize => object.retainedSize;
440 final HeapObject object; 440 final HeapObject object;
441 RetainingObject(this.object); 441 RetainingObject(this.object);
442 } 442 }
443 443
444 abstract class ServiceObjectOwner extends ServiceObject 444 abstract class ServiceObjectOwner extends ServiceObject {
445 implements M.ServiceObjectOwner {
446 /// Creates an empty [ServiceObjectOwner]. 445 /// Creates an empty [ServiceObjectOwner].
447 ServiceObjectOwner._empty(ServiceObjectOwner owner) : super._empty(owner); 446 ServiceObjectOwner._empty(ServiceObjectOwner owner) : super._empty(owner);
448 447
449 /// Builds a [ServiceObject] corresponding to the [id] from [map]. 448 /// Builds a [ServiceObject] corresponding to the [id] from [map].
450 /// The result may come from the cache. The result will not necessarily 449 /// The result may come from the cache. The result will not necessarily
451 /// be [loaded]. 450 /// be [loaded].
452 ServiceObject getFromMap(Map map); 451 ServiceObject getFromMap(Map map);
453 452
454 Future<M.Object> invokeRpc(String method, Map params); 453 Future<M.Object> invokeRpc(String method, Map params);
455 } 454 }
(...skipping 4247 matching lines...) Expand 10 before | Expand all | Expand 10 after
4703 final String alias; 4702 final String alias;
4704 final String method; 4703 final String method;
4705 final String service; 4704 final String service;
4706 4705
4707 Service(this.alias, this.method, this.service) { 4706 Service(this.alias, this.method, this.service) {
4708 assert(this.alias != null); 4707 assert(this.alias != null);
4709 assert(this.method != null); 4708 assert(this.method != null);
4710 assert(this.service != null); 4709 assert(this.service != null);
4711 } 4710 }
4712 } 4711 }
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/sample_profile/sample_profile.dart ('k') | runtime/observatory/observatory_sources.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698