Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2999593002: fix #30330, don't ignore cast failures in DDC for language/lib tests (Closed)

Created:
3 years, 4 months ago by Jennifer Messerly
Modified:
3 years, 4 months ago
Reviewers:
Leaf, Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #30330, don't ignore cast failures in DDC for language/lib tests R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/a77f1514618e3d26ef1c5c446f173ddef867910a

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M tests/corelib_2/corelib_2.status View 2 chunks +5 lines, -1 line 0 comments Download
M tests/corelib_strong/corelib_strong.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language_strong/language_strong.status View 2 chunks +0 lines, -5 lines 0 comments Download
M tests/lib_strong/lib_strong.status View 1 chunk +15 lines, -0 lines 0 comments Download
M tools/testing/dart/browser_test.dart View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jennifer Messerly
fyi, I'll also start taking a look at what the runtime failures are in these ...
3 years, 4 months ago (2017-08-08 02:05:04 UTC) #3
Leaf
lgtm
3 years, 4 months ago (2017-08-08 05:05:21 UTC) #4
Jennifer Messerly
Committed patchset #2 (id:20001) manually as a77f1514618e3d26ef1c5c446f173ddef867910a (presubmit successful).
3 years, 4 months ago (2017-08-09 04:57:53 UTC) #6
Jennifer Messerly
3 years, 4 months ago (2017-08-09 05:51:43 UTC) #7
Message was sent while issue was closed.
On 2017/08/09 04:57:53, Jennifer Messerly wrote:
> Committed patchset #2 (id:20001) manually as
> a77f1514618e3d26ef1c5c446f173ddef867910a (presubmit successful).

Apparently some tests were only set up to run in "checked" for DDC (even though
that flag is completely meaningless) ... working on status file updates

Powered by Google App Engine
This is Rietveld 408576698