Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2656)

Unified Diff: tools/testing/dart/browser_test.dart

Issue 2999593002: fix #30330, don't ignore cast failures in DDC for language/lib tests (Closed)
Patch Set: rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib_strong/lib_strong.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/browser_test.dart
diff --git a/tools/testing/dart/browser_test.dart b/tools/testing/dart/browser_test.dart
index b1a244badebdc64f2d60ab4b5e37f9ed5e219cb3..2fb935ba4acbeb0aa675934adc905f37410b8a84 100644
--- a/tools/testing/dart/browser_test.dart
+++ b/tools/testing/dart/browser_test.dart
@@ -84,15 +84,11 @@ window.ddcSettings = {
<script type="text/javascript">
requirejs(["$testName", "dart_sdk", "async_helper"],
function($testName, dart_sdk, async_helper) {
- function finish() {
- // dev_compiler's test runner (language_test.js) uses this to notify the
- // test results, but it isn't needed for test.dart.
- }
+ dart_sdk.dart.ignoreWhitelistedErrors(false);
// TODO(rnystrom): This uses DDC's forked version of async_helper. Unfork
// these packages when possible.
- async_helper.async_helper.asyncTestInitialize(finish);
-
+ async_helper.async_helper.asyncTestInitialize(function() {});
dart_sdk._isolate_helper.startRootIsolate(function() {}, []);
dartMainRunner($testName.$testName.main);
});
« no previous file with comments | « tests/lib_strong/lib_strong.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698