Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2999483002: tokenserver: Implement InspectOAuthTokenGrant RPC. (Closed)

Created:
3 years, 4 months ago by Vadim Sh.
Modified:
3 years, 4 months ago
Reviewers:
smut
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

tokenserver: Implement InspectOAuthTokenGrant RPC. It can be used by admins to see what's inside of a token (when debugging stuff). R=smut@google.com BUG=731843 Review-Url: https://codereview.chromium.org/2999483002 Committed: https://github.com/luci/luci-go/commit/1339415b6d85915643dab1abfa32d02248e7417a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -3 lines) Patch
M tokenserver/appengine/impl/serviceaccounts/grant.go View 2 chunks +33 lines, -0 lines 0 comments Download
M tokenserver/appengine/impl/serviceaccounts/rpc_inspect_oauth_token_grant.go View 1 chunk +24 lines, -3 lines 0 comments Download
A tokenserver/appengine/impl/serviceaccounts/rpc_inspect_oauth_token_grant_test.go View 1 chunk +127 lines, -0 lines 0 comments Download
M tokenserver/appengine/impl/services/admin/adminsrv/service.go View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Vadim Sh.
Looks like this: https://screenshot.googleplex.com/LxhOHojQMdA.png The implementation is almost copy-pasta of https://github.com/luci/luci-go/blob/master/tokenserver/appengine/impl/delegation/rpc_inspect_delegation_token.go Most of the reusable ...
3 years, 4 months ago (2017-08-05 01:26:08 UTC) #1
smut
lgtm
3 years, 4 months ago (2017-08-05 02:04:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2999483002/1
3 years, 4 months ago (2017-08-05 02:09:55 UTC) #4
commit-bot: I haz the power
3 years, 4 months ago (2017-08-05 02:14:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/1339415b6d85915643dab1abfa32d02248e7417a

Powered by Google App Engine
This is Rietveld 408576698