Issue 299943002: separate view matrix from rt adjustment

Issue 299943002: separate view matrix from rt adjustment (Closed)

Created:
6 years, 7 months ago by bsalomon

Modified:
6 years, 6 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

separate view matrix from rt adjustment Committed: http://code.google.com/p/skia/source/detail?r=14944

Patch Set 2 : add back accidentally deleted code #

Patch Set 3 : revert shader printing #

Total comments: 2

Patch Set 4 : rebase on tot: #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -6 lines)			Patch
M	src/gpu/gl/GrGLProgram.h	View	1	2 chunks	+33 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.h	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View	1 2	1 chunk	+10 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

bsalomon

This is a step towards being able to fiddle with the device-space vertex positions using ...

6 years, 7 months ago (2014-05-23 19:23:53 UTC) #1

robertphillips

lgtm https://codereview.chromium.org/299943002/diff/40001/src/gpu/gl/GrGLShaderBuilder.h File src/gpu/gl/GrGLShaderBuilder.h (right): https://codereview.chromium.org/299943002/diff/40001/src/gpu/gl/GrGLShaderBuilder.h#newcode426 src/gpu/gl/GrGLShaderBuilder.h:426: // comment?

6 years, 7 months ago (2014-05-27 17:07:08 UTC) #3

bsalomon

https://codereview.chromium.org/299943002/diff/40001/src/gpu/gl/GrGLShaderBuilder.h File src/gpu/gl/GrGLShaderBuilder.h (right): https://codereview.chromium.org/299943002/diff/40001/src/gpu/gl/GrGLShaderBuilder.h#newcode426 src/gpu/gl/GrGLShaderBuilder.h:426: On 2014/05/27 17:07:08, robertphillips wrote: > // comment? It's ...

6 years, 6 months ago (2014-05-29 01:04:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/299943002/60001

6 years, 6 months ago (2014-05-29 01:06:49 UTC) #6

Message was sent while issue was closed.

Change committed as 14944

Expand Messages | Collapse Messages