Migrated test block 218 to Dart 2.0.

Migrated test block 218 to Dart 2.0.

Fairly simple block, with changes made to some mirrors tests to make
them strong-mode clean. Modified test script to also accept
*_app_jit.status files.

BUG=
R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/a7a97e41ed3eb604601250cbc20691fc33b8a828

[bkonyi, 2017-08-22 11:07:23]

bkonyi@google.com changed reviewers:
+ rnystrom@google.com

[rmacnak, 2017-08-22 16:56:11]

rmacnak@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2017-08-22 16:56:12]

https://codereview.chromium.org/2999373002/diff/1/tests/lib_2/mirrors/closure...
File tests/lib_2/mirrors/closures_test.dart (right):

https://codereview.chromium.org/2999373002/diff/1/tests/lib_2/mirrors/closure...
tests/lib_2/mirrors/closures_test.dart:11: var closureMirror =
reflect(instance.toString) as ClosureMirror;
This is not equivalent to the original test.
var -> dynamic

https://codereview.chromium.org/2999373002/diff/1/tests/lib_2/mirrors/closure...
tests/lib_2/mirrors/closures_test.dart:19: var closureMirror = reflect(closure)
as ClosureMirror;
"

[Bob Nystrom, 2017-08-23 22:10:06]

lgtm

https://codereview.chromium.org/2999373002/diff/1/tests/lib_2/lib_2_dart2js.s...
File tests/lib_2/lib_2_dart2js.status (right):

https://codereview.chromium.org/2999373002/diff/1/tests/lib_2/lib_2_dart2js.s...
tests/lib_2/lib_2_dart2js.status:29:
mirrors/circular_factory_redirection_test/0*: Pass # expects failure, but it
fails for the wrong reason
As per the email today, you can simplify all of these to a new entry:

[ $compiler == dart2js ]
mirrors/*: SkipByDesign # Mirrors not supported on the web.

Ditto for dartdevc in lib_2_dartdevc.status.

https://codereview.chromium.org/2999373002/diff/1/tests/lib_2/mirrors/class_d...
File tests/lib_2/mirrors/class_declarations_test.dart (right):

https://codereview.chromium.org/2999373002/diff/1/tests/lib_2/mirrors/class_d...
tests/lib_2/mirrors/class_declarations_test.dart:18: }
The "as" expressions aren't accomplishing anything here. It's the dynamic return
type that shuts up the type checker below...

https://codereview.chromium.org/2999373002/diff/1/tests/lib_2/mirrors/class_d...
tests/lib_2/mirrors/class_declarations_test.dart:116: .where((dm) =>
castMirror(dm).isStatic)
You can just do:

(dm) => (dm as dynamic).isStatic

Likewise below.

https://codereview.chromium.org/2999373002/diff/1/tests/lib_2/mirrors/closure...
File tests/lib_2/mirrors/closures_test.dart (right):

https://codereview.chromium.org/2999373002/diff/1/tests/lib_2/mirrors/closure...
tests/lib_2/mirrors/closures_test.dart:11: var closureMirror =
reflect(instance.toString) as ClosureMirror;
On 2017/08/22 16:56:12, rmacnak wrote:
> This is not equivalent to the original test.

That's OK. The main focus of the migration is to change the tests to be valid
Dart 2.0 tests.

If the intent of the test does not require this variable to be dynamically
dispatching things like ".function" and ".apply()", then it's not necessarily to
preserve that in the migrated test.

I think Ben's change looks fine to me. It will help catch bugs in the test
itself if something like a method name is misspelled (which I have seen happen
in our language tests).

[bkonyi, 2017-08-30 14:29:18]

Description was changed from

==========
Migrated test block 218 to Dart 2.0.

Fairly simple block, with changes made to some mirrors tests to make
them strong-mode clean. Modified test script to also accept
*_app_jit.status files.

BUG=
==========

to

==========
Migrated test block 218 to Dart 2.0.

Fairly simple block, with changes made to some mirrors tests to make
them strong-mode clean. Modified test script to also accept
*_app_jit.status files.

BUG=
R=rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a7a97e41ed3eb604601250cbc20691fc33b8a828
==========

[bkonyi, 2017-08-30 14:29:19]

Committed patchset #2 (id:20001) manually as
a7a97e41ed3eb604601250cbc20691fc33b8a828.