Migrated test block 218 to Dart 2.0.

tests/lib_2/mirrors/class_declarations_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.declarations_test;
 
 import 'dart:mirrors';
 import 'package:expect/expect.dart';
 
 import 'stringify.dart';
 import 'declarations_model.dart' as declarations_model;
 
+castMirror(Mirror m) {
+  if (m is DeclarationMirror) return m as DeclarationMirror;
+  if (m is VariableMirror) return m as VariableMirror;
+  if (m is TypeVariableMirror) return m as TypeVariableMirror;
+  return m;
+}

[Bob Nystrom, 2017/08/23 22:10:06]

The "as" expressions aren't accomplishing anything here. It's the dynamic return
type that shuts up the type checker below...

+
 Set<DeclarationMirror> inheritedDeclarations(ClassMirror cm) {
   var decls = new Set<DeclarationMirror>();
   while (cm != null) {
     decls.addAll(cm.declarations.values);
     cm = cm.superclass;
   }
   return decls;
 }
 
 main() {
@@ skipping 25 matching lines @@
         'Method(s(_staticSetter=) in s(Class), private, static, setter)',
         'Method(s(instanceSetter=) in s(Class), setter)',
         'Method(s(staticSetter=) in s(Class), static, setter)'
       ],
       cm.declarations.values
           .where((dm) => dm is MethodMirror && dm.isSetter)
           .map(stringify),
       'setters');
 
   // dart2js stops testing here.
-  return; // //# 01: ok
+  return; //# 01: ok
 
   Expect.setEquals(
       [
         'Method(s(+) in s(Class))',
         'Method(s(_instanceMethod) in s(Class), private)',
         'Method(s(_staticMethod) in s(Class), private, static)',
         'Method(s(abstractMethod) in s(Class), abstract)',
         'Method(s(instanceMethod) in s(Class))',
         'Method(s(staticMethod) in s(Class), static)'
       ],
@@ skipping 13 matching lines @@
         'Method(s(Class.generativeConstructor) in s(Class), constructor)',
         'Method(s(Class.normalFactory) in s(Class), static, constructor)',
         'Method(s(Class.redirectingConstructor) in s(Class), constructor)',
         'Method(s(Class.redirectingFactory) in s(Class), static, constructor)'
       ],
       cm.declarations.values
           .where((dm) => dm is MethodMirror && dm.isConstructor)
           .map(stringify),
       'constructors and factories');
 
-  Expect.setEquals([
-    'Method(s(Class._normalFactory) in s(Class), private, static, constructor)',
-    'Method(s(Class._redirectingFactory)'
-        ' in s(Class), private, static, constructor)',
-    'Method(s(Class.normalFactory) in s(Class), static, constructor)',
-    'Method(s(Class.redirectingFactory) in s(Class), static, constructor)',
-    'Method(s(_staticGetter) in s(Class), private, static, getter)',
-    'Method(s(_staticMethod) in s(Class), private, static)',
-    'Method(s(_staticSetter=) in s(Class), private, static, setter)',
-    'Variable(s(_staticVariable) in s(Class), private, static)',
-    'Method(s(staticGetter) in s(Class), static, getter)',
-    'Method(s(staticMethod) in s(Class), static)',
-    'Method(s(staticSetter=) in s(Class), static, setter)',
-    'Variable(s(staticVariable) in s(Class), static)'
-  ], cm.declarations.values.where((dm) => dm.isStatic).map(stringify),
+  Expect.setEquals(
+      [
+        'Method(s(Class._normalFactory) in s(Class), private, static, constructor)',
+        'Method(s(Class._redirectingFactory)'
+            ' in s(Class), private, static, constructor)',
+        'Method(s(Class.normalFactory) in s(Class), static, constructor)',
+        'Method(s(Class.redirectingFactory) in s(Class), static, constructor)',
+        'Method(s(_staticGetter) in s(Class), private, static, getter)',
+        'Method(s(_staticMethod) in s(Class), private, static)',
+        'Method(s(_staticSetter=) in s(Class), private, static, setter)',
+        'Variable(s(_staticVariable) in s(Class), private, static)',
+        'Method(s(staticGetter) in s(Class), static, getter)',
+        'Method(s(staticMethod) in s(Class), static)',
+        'Method(s(staticSetter=) in s(Class), static, setter)',
+        'Variable(s(staticVariable) in s(Class), static)'
+      ],
+      cm.declarations.values
+          .where((dm) => castMirror(dm).isStatic)

[Bob Nystrom, 2017/08/23 22:10:05]

You can just do:

(dm) => (dm as dynamic).isStatic

Likewise below.

+          .map(stringify),
       'statics');
 
-  Expect.setEquals([
-    'Method(s(+) in s(Class))',
-    'TypeVariable(s(C) in s(Class),'
-        ' upperBound = Class(s(Object) in s(dart.core), top-level))',
-    'Method(s(Class._generativeConstructor) in s(Class), private, constructor)',
-    'Method(s(Class._redirectingConstructor)'
-        ' in s(Class), private, constructor)',
-    'Method(s(Class.generativeConstructor) in s(Class), constructor)',
-    'Method(s(Class.redirectingConstructor) in s(Class), constructor)',
-    'Method(s(_instanceGetter) in s(Class), private, getter)',
-    'Method(s(_instanceMethod) in s(Class), private)',
-    'Method(s(_instanceSetter=) in s(Class), private, setter)',
-    'Variable(s(_instanceVariable) in s(Class), private)',
-    'Method(s(abstractMethod) in s(Class), abstract)',
-    'Method(s(instanceGetter) in s(Class), getter)',
-    'Method(s(instanceMethod) in s(Class))',
-    'Method(s(instanceSetter=) in s(Class), setter)',
-    'Variable(s(instanceVariable) in s(Class))'
-  ], cm.declarations.values.where((dm) => !dm.isStatic).map(stringify),
+  Expect.setEquals(
+      [
+        'Method(s(+) in s(Class))',
+        'TypeVariable(s(C) in s(Class),'
+            ' upperBound = Class(s(Object) in s(dart.core), top-level))',
+        'Method(s(Class._generativeConstructor) in s(Class), private, constructor)',
+        'Method(s(Class._redirectingConstructor)'
+            ' in s(Class), private, constructor)',
+        'Method(s(Class.generativeConstructor) in s(Class), constructor)',
+        'Method(s(Class.redirectingConstructor) in s(Class), constructor)',
+        'Method(s(_instanceGetter) in s(Class), private, getter)',
+        'Method(s(_instanceMethod) in s(Class), private)',
+        'Method(s(_instanceSetter=) in s(Class), private, setter)',
+        'Variable(s(_instanceVariable) in s(Class), private)',
+        'Method(s(abstractMethod) in s(Class), abstract)',
+        'Method(s(instanceGetter) in s(Class), getter)',
+        'Method(s(instanceMethod) in s(Class))',
+        'Method(s(instanceSetter=) in s(Class), setter)',
+        'Variable(s(instanceVariable) in s(Class))'
+      ],
+      cm.declarations.values
+          .where((dm) => !castMirror(dm).isStatic)
+          .map(stringify),
       'non-statics');
 
-  Expect.setEquals([
-    'Method(s(+) in s(Class))',
-    'TypeVariable(s(C) in s(Class),'
-        ' upperBound = Class(s(Object) in s(dart.core), top-level))',
-    'Method(s(Class.generativeConstructor) in s(Class), constructor)',
-    'Method(s(Class.normalFactory) in s(Class), static, constructor)',
-    'Method(s(Class.redirectingConstructor) in s(Class), constructor)',
-    'Method(s(Class.redirectingFactory) in s(Class), static, constructor)',
-    'Method(s(abstractMethod) in s(Class), abstract)',
-    'Method(s(instanceGetter) in s(Class), getter)',
-    'Method(s(instanceMethod) in s(Class))',
-    'Method(s(instanceSetter=) in s(Class), setter)',
-    'Variable(s(instanceVariable) in s(Class))',
-    'Method(s(staticGetter) in s(Class), static, getter)',
-    'Method(s(staticMethod) in s(Class), static)',
-    'Method(s(staticSetter=) in s(Class), static, setter)',
-    'Variable(s(staticVariable) in s(Class), static)'
-  ], cm.declarations.values.where((dm) => !dm.isPrivate).map(stringify),
+  Expect.setEquals(
+      [
+        'Method(s(+) in s(Class))',
+        'TypeVariable(s(C) in s(Class),'
+            ' upperBound = Class(s(Object) in s(dart.core), top-level))',
+        'Method(s(Class.generativeConstructor) in s(Class), constructor)',
+        'Method(s(Class.normalFactory) in s(Class), static, constructor)',
+        'Method(s(Class.redirectingConstructor) in s(Class), constructor)',
+        'Method(s(Class.redirectingFactory) in s(Class), static, constructor)',
+        'Method(s(abstractMethod) in s(Class), abstract)',
+        'Method(s(instanceGetter) in s(Class), getter)',
+        'Method(s(instanceMethod) in s(Class))',
+        'Method(s(instanceSetter=) in s(Class), setter)',
+        'Variable(s(instanceVariable) in s(Class))',
+        'Method(s(staticGetter) in s(Class), static, getter)',
+        'Method(s(staticMethod) in s(Class), static)',
+        'Method(s(staticSetter=) in s(Class), static, setter)',
+        'Variable(s(staticVariable) in s(Class), static)'
+      ],
+      cm.declarations.values
+          .where((dm) => !castMirror(dm).isPrivate)
+          .map(stringify),
       'public');
 
   Expect.setEquals([
     'Method(s(*) in s(Mixin))',
     'Method(s(+) in s(Class))',
     'Method(s(-) in s(Superclass))',
     'Method(s(==) in s(Object))',
     'TypeVariable(s(C) in s(Class),'
         ' upperBound = Class(s(Object) in s(dart.core), top-level))',
     'Method(s(Class.generativeConstructor) in s(Class), constructor)',
@@ skipping 189 matching lines @@
         'Method(s(_mixinStaticSetter=) in s(Mixin), private, static, setter)',
         'Method(s(_mixinStaticMethod) in s(Mixin), private, static)'
       ],
       inheritedDeclarations(cm)
           .difference(reflectClass(Object).declarations.values.toSet())
           .map(stringify),
       'transitive less Object');
   // The private members of Object may vary across implementations, so we
   // exclude the declarations of Object in this test case.
 }