Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 299923005: Revert 272565 "Re-land: cc: Fail more visibly when sync queries ..." (Closed)

Created:
6 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 7 months ago
Reviewers:
reveman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 272565 "Re-land: cc: Fail more visibly when sync queries ..." Caused two native crashes in contentshell_instrumentation_tests on Android Tests (dbg) bot on Blink waterfall. BUG=377053, 371530, 373360 > Re-land: cc: Fail more visibly when sync queries are not working correctly. > > Instead of creating an infinite number of sync queries, which will > eventually cause performance issues, log an error message and block > until oldest query has passed when reaching 16 pending queries. > > BUG=371530, 373360 > > Review URL: https://codereview.chromium.org/280543003 TBR=reveman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M trunk/src/cc/output/gl_renderer.cc View 3 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ken Russell (switch to Gerrit)
6 years, 7 months ago (2014-05-23 23:41:35 UTC) #1
Ken Russell (switch to Gerrit)
6 years, 7 months ago (2014-05-23 23:41:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r272638.

Powered by Google App Engine
This is Rietveld 408576698