Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 280543003: Re-land: cc: Fail more visibly when sync queries are not working correctly. (Closed)

Created:
6 years, 7 months ago by reveman
Modified:
6 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Re-land: cc: Fail more visibly when sync queries are not working correctly. Instead of creating an infinite number of sync queries, which will eventually cause performance issues, log an error message and block until oldest query has passed when reaching 16 pending queries. BUG=371530, 373360 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273255

Patch Set 1 #

Patch Set 2 : signed/unsigned compare fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M cc/output/gl_renderer.cc View 1 3 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
reveman
6 years, 7 months ago (2014-05-12 19:22:15 UTC) #1
piman
lgtm
6 years, 7 months ago (2014-05-12 19:41:08 UTC) #2
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 7 months ago (2014-05-12 21:00:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/280543003/1
6 years, 7 months ago (2014-05-12 21:01:27 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 00:34:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 00:48:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/183197)
6 years, 7 months ago (2014-05-13 00:48:37 UTC) #7
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 7 months ago (2014-05-13 15:52:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/280543003/20001
6 years, 7 months ago (2014-05-13 15:52:24 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 18:54:55 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 22:11:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/15549)
6 years, 7 months ago (2014-05-13 22:11:28 UTC) #12
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 7 months ago (2014-05-13 22:14:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/280543003/20001
6 years, 7 months ago (2014-05-13 22:14:58 UTC) #14
commit-bot: I haz the power
Change committed as 270265
6 years, 7 months ago (2014-05-14 00:26:45 UTC) #15
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 7 months ago (2014-05-23 18:26:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/280543003/20001
6 years, 7 months ago (2014-05-23 18:26:48 UTC) #17
commit-bot: I haz the power
Change committed as 272565
6 years, 7 months ago (2014-05-23 18:28:52 UTC) #18
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 6 months ago (2014-05-28 15:58:15 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/280543003/20001
6 years, 6 months ago (2014-05-28 15:59:52 UTC) #20
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 16:01:51 UTC) #21
Message was sent while issue was closed.
Change committed as 273255

Powered by Google App Engine
This is Rietveld 408576698