Run VideoProcessor on task queue in VideoProcessorIntegrationTest.

Run VideoProcessor on task queue in VideoProcessorIntegrationTest.

This CL runs the VideoProcessor on a task queue, so that we can support
Android HW codecs. The CL also does several other changes:

VideoProcessorIntegrationTest:
* Split up frame processing and rate control calculations.
* Remove batch mode. This is no longer necessary due to the change above.
* Simplify frame number "accounting". Now we will exactly process
  |rate_profile.num_frames| number of frames -- no more, no less.
* Make rate control and quality thresholds optional. This is useful for the
  test in plot_videoprocessor_integrationtest.cc.
* Make VerifyQuality and NumberOfTemporalLayer static, in preparation of
  moving them to be helper functions in an anonymous namespace.
* Rename some methods.
* Shorten the visualization file names.
* Reorganize function calls in videoprocessor_integrationtest.cc.

VideoProcessor:
* Add sequenced task checker.
* Let ProcessFrame return void.
* Make |encode_callback_| and |decode_callback_| direct members, and let them
  post callbacks on the task queue if needed.
* Remove unused |timestamp| from FrameInfo struct.
* Remove EncodedFrameSize and EncodedFrameType methods. Use the |stats_|
  object to persist this information instead.
* Reorder printf output from PrintCodecSettings.
* Make some member functions const.
* Extend unit tests.

TESTED=By comparing the stdout output from videoprocessor_integrationtest.cc before and after this CL. Also tested plot_videoprocessor_integrationtest.cc on an Android device. Not tested on iOS, due to provisioning profile problems.
BUG=webrtc:6634

[brandtr, 2017-08-17 08:19:43]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-17 08:19:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-17 08:32:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-17 08:32:23]

Dry run: Try jobs failed on following builders:
  linux_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_dbg/builds/...)

[brandtr, 2017-08-17 10:50:41]

Patchset #1 (id:1) has been deleted

[brandtr, 2017-08-17 11:14:52]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-17 11:14:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[brandtr, 2017-08-17 11:24:27]

Description was changed from

==========
Run VideoProcessor on task queue in VideoProcessorIntegrationTest.

This CL runs the VideoProcessor on a task queue, so that we can support
Android HW codecs. The CL also does several other changes:

VideoProcessorIntegrationTest:
* Split up frame processing and rate control calculations.
* Remove batch mode. This is no longer necessary due to the change above.
* Simplify frame number "accounting". Now we will exactly process
  |rate_profile.num_frames| number of frames -- no more, no less.
* Make rate control and quality thresholds optional. This is useful for the
  test in plot_videoprocessor_integrationtest.cc.
* Make VerifyQuality and NumberOfTemporalLayer static, in preparation of
  moving them to be helper functions in an anonymous namespace.
* Rename some methods.
* Shorten the visualization file names.
* Reorganize function calls in videoprocessor_integrationtest.cc.

VideoProcessor:
* Add sequenced task checker.
* Let ProcessFrame return void.
* Make |encode_callback_| and |decode_callback_| direct members, and let them
  post callbacks on the task queue if needed.
* Remove unused |timestamp| from FrameInfo struct.
* Remove EncodedFrameSize and EncodedFrameType methods. Use the |stats_|
  object to persist this information instead.
* Reorder printf output from PrintCodecSettings.
* Make some member functions const.
* Extend unit tests.

BUG=webrtc:6634
==========

to

==========
Run VideoProcessor on task queue in VideoProcessorIntegrationTest.

This CL runs the VideoProcessor on a task queue, so that we can support
Android HW codecs. The CL also does several other changes:

VideoProcessorIntegrationTest:
* Split up frame processing and rate control calculations.
* Remove batch mode. This is no longer necessary due to the change above.
* Simplify frame number "accounting". Now we will exactly process
  |rate_profile.num_frames| number of frames -- no more, no less.
* Make rate control and quality thresholds optional. This is useful for the
  test in plot_videoprocessor_integrationtest.cc.
* Make VerifyQuality and NumberOfTemporalLayer static, in preparation of
  moving them to be helper functions in an anonymous namespace.
* Rename some methods.
* Shorten the visualization file names.
* Reorganize function calls in videoprocessor_integrationtest.cc.

VideoProcessor:
* Add sequenced task checker.
* Let ProcessFrame return void.
* Make |encode_callback_| and |decode_callback_| direct members, and let them
  post callbacks on the task queue if needed.
* Remove unused |timestamp| from FrameInfo struct.
* Remove EncodedFrameSize and EncodedFrameType methods. Use the |stats_|
  object to persist this information instead.
* Reorder printf output from PrintCodecSettings.
* Make some member functions const.
* Extend unit tests.

TESTED=By comparing the stdout output from before/after this CL. Also run on an
Android device. Not tested on iOS, due to provisioning profile problems.
BUG=webrtc:6634
==========

[brandtr, 2017-08-17 11:25:09]

Description was changed from

==========
Run VideoProcessor on task queue in VideoProcessorIntegrationTest.

This CL runs the VideoProcessor on a task queue, so that we can support
Android HW codecs. The CL also does several other changes:

VideoProcessorIntegrationTest:
* Split up frame processing and rate control calculations.
* Remove batch mode. This is no longer necessary due to the change above.
* Simplify frame number "accounting". Now we will exactly process
  |rate_profile.num_frames| number of frames -- no more, no less.
* Make rate control and quality thresholds optional. This is useful for the
  test in plot_videoprocessor_integrationtest.cc.
* Make VerifyQuality and NumberOfTemporalLayer static, in preparation of
  moving them to be helper functions in an anonymous namespace.
* Rename some methods.
* Shorten the visualization file names.
* Reorganize function calls in videoprocessor_integrationtest.cc.

VideoProcessor:
* Add sequenced task checker.
* Let ProcessFrame return void.
* Make |encode_callback_| and |decode_callback_| direct members, and let them
  post callbacks on the task queue if needed.
* Remove unused |timestamp| from FrameInfo struct.
* Remove EncodedFrameSize and EncodedFrameType methods. Use the |stats_|
  object to persist this information instead.
* Reorder printf output from PrintCodecSettings.
* Make some member functions const.
* Extend unit tests.

TESTED=By comparing the stdout output from before/after this CL. Also run on an
Android device. Not tested on iOS, due to provisioning profile problems.
BUG=webrtc:6634
==========

to

==========
Run VideoProcessor on task queue in VideoProcessorIntegrationTest.

This CL runs the VideoProcessor on a task queue, so that we can support
Android HW codecs. The CL also does several other changes:

VideoProcessorIntegrationTest:
* Split up frame processing and rate control calculations.
* Remove batch mode. This is no longer necessary due to the change above.
* Simplify frame number "accounting". Now we will exactly process
  |rate_profile.num_frames| number of frames -- no more, no less.
* Make rate control and quality thresholds optional. This is useful for the
  test in plot_videoprocessor_integrationtest.cc.
* Make VerifyQuality and NumberOfTemporalLayer static, in preparation of
  moving them to be helper functions in an anonymous namespace.
* Rename some methods.
* Shorten the visualization file names.
* Reorganize function calls in videoprocessor_integrationtest.cc.

VideoProcessor:
* Add sequenced task checker.
* Let ProcessFrame return void.
* Make |encode_callback_| and |decode_callback_| direct members, and let them
  post callbacks on the task queue if needed.
* Remove unused |timestamp| from FrameInfo struct.
* Remove EncodedFrameSize and EncodedFrameType methods. Use the |stats_|
  object to persist this information instead.
* Reorder printf output from PrintCodecSettings.
* Make some member functions const.
* Extend unit tests.

TESTED=By comparing the stdout output from videoprocessor_integrationtest.cc
before and after this CL. Also tested plot_videoprocessor_integrationtest.cc on
an Android device. Not tested on iOS, due to provisioning profile problems.
BUG=webrtc:6634
==========

[commit-bot: I haz the power, 2017-08-17 12:06:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-17 12:06:08]

Dry run: This issue passed the CQ dry run.

[brandtr, 2017-08-17 12:07:06]

brandtr@webrtc.org changed reviewers:
+ asapersson@webrtc.org

[kthelgason, 2017-08-18 09:36:41]

On 2017/08/17 12:07:06, brandtr wrote:

This implementation deadlocks on iOS when using H264, I think we need to do
further testing to make it usable there.

[brandtr, 2017-08-18 10:17:22]

On 2017/08/18 09:36:41, kthelgason wrote:
> On 2017/08/17 12:07:06, brandtr wrote:
> 
> This implementation deadlocks on iOS when using H264, I think we need to do
> further testing to make it usable there.

Good input, thanks. I haven't manage to test it on iOS, because of provisioning
profile problems. Will do that when I sort out the problems.

[brandtr, 2017-08-21 08:18:36]

As requested, split this CL up in smaller pieces to make it easier to review:

https://codereview.webrtc.org/2998063002/
https://codereview.webrtc.org/3001193002/
https://codereview.webrtc.org/2996253002/

One more is coming.