Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2999063002: Add flag enabling more packets to be retransmittable. (Closed)

Created:
3 years, 4 months ago by sprang_webrtc
Modified:
3 years, 3 months ago
Reviewers:
brandtr, danilchap
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add flag enabling more packets to be retransmittable. If not indicated otherwise, allow adding a packet to the retransmission history at least every 1/15s in order to reduce frame dropping. BUG=webrtc:7694 Review-Url: https://codereview.webrtc.org/2999063002 Cr-Commit-Position: refs/heads/master@{#19665} Committed: https://chromium.googlesource.com/external/webrtc/+/a8ae6f2acaef86e63f349442dbde8e81a9bd041e

Patch Set 1 #

Patch Set 2 : Temporal layer based conditional retransmit #

Patch Set 3 : include cleanup #

Patch Set 4 : cleanup #

Patch Set 5 : Cleanup, rebase #

Patch Set 6 : Add tests #

Patch Set 7 : whitespace #

Total comments: 38

Patch Set 8 : Removed GetStorageType and ProtectionType from packetizers. Refactorings. Addressed comments. #

Total comments: 25

Patch Set 9 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+460 lines, -172 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_video_generic.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_video_generic.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp8.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp8.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -19 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp9.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp9.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -18 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -31 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 2 3 4 5 6 7 2 chunks +13 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 2 3 4 5 6 7 7 chunks +21 lines, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 2 3 4 5 6 7 8 22 chunks +287 lines, -45 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.h View 1 2 3 4 5 6 7 8 6 chunks +31 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 1 2 3 4 5 6 7 8 7 chunks +101 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
sprang_webrtc
3 years, 3 months ago (2017-08-29 14:40:53 UTC) #7
danilchap
1st round mostly with style comments. Will take another round tomorrow. https://codereview.webrtc.org/2999063002/diff/120001/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h File webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h (right): ...
3 years, 3 months ago (2017-08-29 17:31:20 UTC) #8
danilchap
https://codereview.webrtc.org/2999063002/diff/120001/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc File webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc (right): https://codereview.webrtc.org/2999063002/diff/120001/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc#newcode437 webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc:437: &expected_retransmission_time_ms, nullptr, can add comment which of many rtts ...
3 years, 3 months ago (2017-08-30 13:52:29 UTC) #9
sprang_webrtc
+brandtr in case there are any concerns for fec re refactoring of GetProtectionType https://codereview.webrtc.org/2999063002/diff/120001/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h File ...
3 years, 3 months ago (2017-08-31 15:54:29 UTC) #11
danilchap
https://codereview.webrtc.org/2999063002/diff/120001/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc File webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc (right): https://codereview.webrtc.org/2999063002/diff/120001/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc#newcode462 webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc:462: RTPSenderVideo::TemporalLayerStats* RTPSenderVideo::GetTemporalLayerStats( On 2017/08/31 15:54:29, sprang_webrtc wrote: > On ...
3 years, 3 months ago (2017-09-04 09:03:05 UTC) #12
brandtr
GetProtectionType changes lgtm https://codereview.webrtc.org/2999063002/diff/140001/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc File webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc (right): https://codereview.webrtc.org/2999063002/diff/140001/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc#newcode404 webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc:404: const uint8_t temporal_id = Reuse |temporal_id| ...
3 years, 3 months ago (2017-09-04 10:29:22 UTC) #13
sprang_webrtc
https://codereview.webrtc.org/2999063002/diff/120001/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc File webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc (right): https://codereview.webrtc.org/2999063002/diff/120001/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc#newcode462 webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc:462: RTPSenderVideo::TemporalLayerStats* RTPSenderVideo::GetTemporalLayerStats( On 2017/09/04 09:03:04, danilchap wrote: > On ...
3 years, 3 months ago (2017-09-04 11:09:29 UTC) #14
danilchap
lgtm https://codereview.webrtc.org/2999063002/diff/140001/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right): https://codereview.webrtc.org/2999063002/diff/140001/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc#newcode269 webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:269: auto packetizer = rtc::WrapUnique(RtpPacketizer::Create( On 2017/09/04 11:09:28, sprang_webrtc ...
3 years, 3 months ago (2017-09-04 11:19:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2999063002/160001
3 years, 3 months ago (2017-09-04 12:09:00 UTC) #18
commit-bot: I haz the power
3 years, 3 months ago (2017-09-04 14:24:04 UTC) #21
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/external/webrtc/+/a8ae6f2acaef86e63f349442d...

Powered by Google App Engine
This is Rietveld 408576698