Convert WebRtcLoggingHandlerHost to use the blocking thread pool.

Convert WebRtcLoggingHandlerHost to use the blocking thread pool.

Also call base::GetLinuxDistro() on the blocking pool and not on the IO thread
because it may block.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274615

[Henrik Grunell, 2014-05-28 07:12:57]

lgtm

[Lei Zhang, 2014-05-28 07:28:36]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-28 07:29:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/299903002/1

[commit-bot: I haz the power, 2014-05-28 09:19:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-28 10:22:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 10:22:59]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Lei Zhang, 2014-05-28 22:01:11]

I failed a DCHECK and had to fix a few more spots, mostly with similar patterns.

[Lei Zhang, 2014-05-28 22:01:15]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-28 22:05:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/299903002/40001

[commit-bot: I haz the power, 2014-05-29 02:47:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-29 06:08:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-29 06:08:35]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Lei Zhang, 2014-05-29 07:17:32]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-29 07:18:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/299903002/40001

[Henrik Grunell, 2014-05-29 17:46:28]

https://codereview.chromium.org/299903002/diff/40001/chrome/browser/media/web...
File chrome/browser/media/webrtc_logging_handler_host.cc (right):

https://codereview.chromium.org/299903002/diff/40001/chrome/browser/media/web...
chrome/browser/media/webrtc_logging_handler_host.cc:476:
base::Bind(&WebRtcLogUploader::LoggingStoppedDoUpload,
WebRtcLogUploader needs to be called on the file thread. (Or post a sequenced
task, but the thread checker in the uploader will fail afaik.)

[Henrik Grunell, 2014-05-29 17:51:23]

The CQ bit was unchecked by grunell@chromium.org

[Lei Zhang, 2014-05-29 23:45:45]

On 2014/05/29 17:46:28, Henrik Grunell wrote:
>
https://codereview.chromium.org/299903002/diff/40001/chrome/browser/media/web...
> File chrome/browser/media/webrtc_logging_handler_host.cc (right):
> 
>
https://codereview.chromium.org/299903002/diff/40001/chrome/browser/media/web...
> chrome/browser/media/webrtc_logging_handler_host.cc:476:
> base::Bind(&WebRtcLogUploader::LoggingStoppedDoUpload,
> WebRtcLogUploader needs to be called on the file thread. (Or post a sequenced
> task, but the thread checker in the uploader will fail afaik.)

I fixed WebRtcLogUploader in patch set 3. I think that's the extent of this CL.

[Henrik Grunell, 2014-05-30 06:57:40]

https://codereview.chromium.org/299903002/diff/40001/chrome/browser/media/web...
File chrome/browser/media/webrtc_logging_handler_host.cc (right):

https://codereview.chromium.org/299903002/diff/40001/chrome/browser/media/web...
chrome/browser/media/webrtc_logging_handler_host.cc:476:
base::Bind(&WebRtcLogUploader::LoggingStoppedDoUpload,
On 2014/05/29 17:46:29, Henrik Grunell wrote:
> WebRtcLogUploader needs to be called on the file thread. (Or post a sequenced
> task, but the thread checker in the uploader will fail afaik.)

Doesn't this need to be a sequenced task to ensure order and that task 1
finishes before task 2 is started?

https://codereview.chromium.org/299903002/diff/60001/chrome/browser/media/web...
File chrome/browser/media/webrtc_log_uploader.cc (right):

https://codereview.chromium.org/299903002/diff/60001/chrome/browser/media/web...
chrome/browser/media/webrtc_log_uploader.cc:74:
content::BrowserThread::PostBlockingPoolTask(
Doesn't this need to the sequenced?

https://codereview.chromium.org/299903002/diff/60001/chrome/browser/media/web...
File chrome/browser/media/webrtc_log_uploader.h (right):

https://codereview.chromium.org/299903002/diff/60001/chrome/browser/media/web...
chrome/browser/media/webrtc_log_uploader.h:165: // on the FILE thread.
Update comment.

[Lei Zhang, 2014-05-31 00:55:52]

https://codereview.chromium.org/299903002/diff/60001/chrome/browser/media/web...
File chrome/browser/media/webrtc_log_uploader.cc (right):

https://codereview.chromium.org/299903002/diff/60001/chrome/browser/media/web...
chrome/browser/media/webrtc_log_uploader.cc:74:
content::BrowserThread::PostBlockingPoolTask(
On 2014/05/30 06:57:40, Henrik Grunell wrote:
> Doesn't this need to the sequenced?

Only if we read from + write to the same |log_list_path| simultaneously. That
can only happen if |local_log_id| in WebRtcLogUploader::LoggingStoppedDoUpload()
is the same for two separate calls. Since |local_log_id| is generated from a
timestamp, the chances of someone changing the time and being able to hit the
exact same timestamp again is very very small.

[Lei Zhang, 2014-05-31 00:56:51]

https://codereview.chromium.org/299903002/diff/60001/chrome/browser/media/web...
File chrome/browser/media/webrtc_log_uploader.h (right):

https://codereview.chromium.org/299903002/diff/60001/chrome/browser/media/web...
chrome/browser/media/webrtc_log_uploader.h:165: // on the FILE thread.
On 2014/05/30 06:57:40, Henrik Grunell wrote:
> Update comment.

Done.

[Henrik Grunell, 2014-06-02 06:49:17]

LGTM if you verify the final comment. Thanks for doing the changes in this CL!

https://codereview.chromium.org/299903002/diff/80001/chrome/browser/media/web...
File chrome/browser/media/webrtc_log_uploader.h (right):

https://codereview.chromium.org/299903002/diff/80001/chrome/browser/media/web...
chrome/browser/media/webrtc_log_uploader.h:88: void
OverrideUploadWithBufferForTesting(std::string* post_data) {
Will the tests that call this need to be updated?

[Lei Zhang, 2014-06-03 00:16:17]

https://codereview.chromium.org/299903002/diff/80001/chrome/browser/media/web...
File chrome/browser/media/webrtc_log_uploader.h (right):

https://codereview.chromium.org/299903002/diff/80001/chrome/browser/media/web...
chrome/browser/media/webrtc_log_uploader.h:88: void
OverrideUploadWithBufferForTesting(std::string* post_data) {
On 2014/06/02 06:49:18, Henrik Grunell wrote:
> Will the tests that call this need to be updated?

Should be ok based on the way it's used.

[Lei Zhang, 2014-06-03 00:16:21]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-03 00:16:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/299903002/100001

[commit-bot: I haz the power, 2014-06-03 04:13:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-03 04:56:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-03 04:56:40]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Lei Zhang, 2014-06-03 08:45:54]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-03 08:47:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/299903002/120001

[commit-bot: I haz the power, 2014-06-03 12:31:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)

[commit-bot: I haz the power, 2014-06-03 13:16:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-03 13:16:48]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[Lei Zhang, 2014-06-03 19:26:21]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-03 19:27:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/299903002/120001

[commit-bot: I haz the power, 2014-06-03 20:52:41]

Change committed as 274615