Convert WebRtcLoggingHandlerHost to use the blocking thread pool.

chrome/browser/media/webrtc_log_uploader.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_WEBRTC_LOG_UPLOADER_H_
 #define CHROME_BROWSER_MEDIA_WEBRTC_LOG_UPLOADER_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
+#include "base/sequence_checker.h"
 #include "base/threading/thread_checker.h"
 #include "chrome/browser/media/webrtc_logging_handler_host.h"
 #include "net/url_request/url_fetcher_delegate.h"
 
 class Profile;
 
 namespace base {
 class SharedMemory;
 }
 
@@ skipping 87 matching lines @@
 
   void ResizeForNextOutput(std::vector<uint8>* compressed_log,
                            z_stream* stream);
 
   void CreateAndStartURLFetcher(
       const WebRtcLogUploadDoneData& upload_done_data,
       scoped_ptr<std::string> post_data);
 
   void DecreaseLogCount();
 
-  // Must be called on the FILE thread.
+  // Must be called on the blocking task pool.
   void WriteCompressedLogToFile(const std::vector<uint8>& compressed_log,
                                 const base::FilePath& log_file_path);
 
   // Append information (upload time, report ID and local ID) about a log to a
   // log list file, limited to |kLogListLimitLines| entries. This list is used
   // for viewing the logs under chrome://webrtc-logs, see WebRtcLogUploadList.
   // The list has the format
   // upload_time,report_id,local_id
   // upload_time,report_id,local_id
   // etc.
   // where each line represents a log. "upload_time" is the time when the log
   // was uploaded in Unix time. "report_id" is the ID reported back by the
   // server. "local_id" is the ID for the locally stored log. It's the time
   // stored in Unix time and it's also used as file name.
   // AddLocallyStoredLogInfoToUploadListFile() will first be called,
   // "upload_time" and "report_id" is the left empty in the entry written to the
   // list file. If uploading is successful, AddUploadedLogInfoToUploadListFile()
   // is called and those empty items are filled out.
-  // Must be called on the FILE thread.
+  // Must be called on the blocking task pool.
   void AddLocallyStoredLogInfoToUploadListFile(
       const base::FilePath& upload_list_path,
       const std::string& local_log_id);
   void AddUploadedLogInfoToUploadListFile(
       const base::FilePath& upload_list_path,
       const std::string& local_log_id,
       const std::string& report_id);
 
   void NotifyUploadDone(int response_code,
                         const std::string& report_id,
                         const WebRtcLogUploadDoneData& upload_done_data);
 
   // This is the UI thread for Chromium. Some other thread for tests.
   base::ThreadChecker create_thread_checker_;
 
-  // This is the FILE thread for Chromium. Some other thread for tests.
-  base::ThreadChecker file_thread_checker_;
+  // This is the blocking task pool.
+  base::SequenceChecker blocking_sequence_checker_;
 
   // Keeps track of number of currently open logs. Must be accessed on the UI
   // thread.
   int log_count_;
 
   // For testing purposes, see OverrideUploadWithBufferForTesting. Only accessed
   // on the FILE thread.

[Henrik Grunell, 2014/05/30 06:57:40]

Update comment.

[Lei Zhang, 2014/05/31 00:56:52]

Done.

   std::string* post_data_;
 
   typedef std::map<const net::URLFetcher*, WebRtcLogUploadDoneData>
       UploadDoneDataMap;
   // Only accessed on the UI thread.
   UploadDoneDataMap upload_done_data_;
 
   // When shutting down, don't create new URLFetchers.
   bool shutting_down_;
 
   DISALLOW_COPY_AND_ASSIGN(WebRtcLogUploader);
 };
 
 #endif  // CHROME_BROWSER_MEDIA_WEBRTC_LOG_UPLOADER_H_