Use timeout to read most recent build from http

Use timeout to read most recent build from http

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/aa7f14aed3907e251bc90fdabc9fefe0a5a219cd

[Johnni Winther, 2017-08-15 09:17:02]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2017-08-15 11:26:35]

LGTM.

https://codereview.chromium.org/2998993002/diff/20001/tools/gardening/lib/src...
File tools/gardening/lib/src/util.dart (right):

https://codereview.chromium.org/2998993002/diff/20001/tools/gardening/lib/src...
tools/gardening/lib/src/util.dart:67: class TimeoutException implements
Exception {
I would have used the builtin TimeoutException class.

It doesn't have a uri field, but it doesn't look like that one is used anyway.

https://codereview.chromium.org/2998993002/diff/20001/tools/gardening/lib/src...
tools/gardening/lib/src/util.dart:87: StreamSubscription subscription =
response.listen((List<int> buffer) {
You could consider using .timeout from the Stream class.

return response
    .timeout(timeout)
    .toList()
    .then((chunks) => chunks.expand((x) => x).toList());


The expand might be too expensive, but then you could just do a small loop in
the .then (calling `addAll` on a fresh list.

[Johnni Winther, 2017-08-15 12:36:32]

Description was changed from

==========
Use timeout to read most recent build from http
==========

to

==========
Use timeout to read most recent build from http

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/aa7f14aed3907e251bc90fdabc9fefe0a5a219cd
==========

[Johnni Winther, 2017-08-15 12:36:34]

Committed patchset #3 (id:40001) manually as
aa7f14aed3907e251bc90fdabc9fefe0a5a219cd (presubmit successful).

[Johnni Winther, 2017-08-15 12:51:28]

https://codereview.chromium.org/2998993002/diff/20001/tools/gardening/lib/src...
File tools/gardening/lib/src/util.dart (right):

https://codereview.chromium.org/2998993002/diff/20001/tools/gardening/lib/src...
tools/gardening/lib/src/util.dart:67: class TimeoutException implements
Exception {
On 2017/08/15 11:26:35, floitsch wrote:
> I would have used the builtin TimeoutException class.
> 
> It doesn't have a uri field, but it doesn't look like that one is used anyway.

Done.

https://codereview.chromium.org/2998993002/diff/20001/tools/gardening/lib/src...
tools/gardening/lib/src/util.dart:87: StreamSubscription subscription =
response.listen((List<int> buffer) {
On 2017/08/15 11:26:35, floitsch wrote:
> You could consider using .timeout from the Stream class.
> 
> return response
>     .timeout(timeout)
>     .toList()
>     .then((chunks) => chunks.expand((x) => x).toList());
> 
> 
> The expand might be too expensive, but then you could just do a small loop in
> the .then (calling `addAll` on a fresh list.

Done.