tools/gardening/bin/current_summary.dart - Issue 2998993002: Use timeout to read most recent build from http

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gardening/bin/current_summary.dart

Issue 2998993002: Use timeout to read most recent build from http (Closed)

Patch Set: Updated cf. comments Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gardening/bin/current_summary.dart

diff --git a/tools/gardening/bin/current_summary.dart b/tools/gardening/bin/current_summary.dart

index ff9520d4f6b1007c6e956189bbdf1ab5214b17ea..da3261bb1a666a3a10067d333fc4e8d06e4c0436 100644

--- a/tools/gardening/bin/current_summary.dart

+++ b/tools/gardening/bin/current_summary.dart

@@ -57,8 +57,6 @@ main(List<String> args) async {

log('Skipping group $group');

continue;

}

- // TODO(johnniwinther): Support reading a partially completed shard from

- // http, i.e. always use build number `-1`.

List<BuildUri> uriList = group.createUris(bot.mostRecentBuildNumber);

if (uriList.isEmpty) continue;

print('Fetching "${uriList.first}" + ${uriList.length - 1} more ...');

« no previous file with comments | « no previous file | tools/gardening/lib/src/buildbot_loading.dart » ('j') | no next file with comments »