Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 2998933002: move endMetadataStar (Closed)

Created:
3 years, 4 months ago by danrubel
Modified:
3 years, 4 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/unhandled_listener.dart View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
3 years, 4 months ago (2017-08-14 16:39:30 UTC) #2
ahe
lgtm An alternative would be to move it to StackListener.
3 years, 4 months ago (2017-08-15 07:43:39 UTC) #3
danrubel
On 2017/08/15 07:43:39, ahe wrote: > lgtm > > An alternative would be to move ...
3 years, 4 months ago (2017-08-15 15:50:28 UTC) #4
danrubel
3 years, 4 months ago (2017-08-15 17:49:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
edc043a83b40954a351e4a2aa98fba7c14fbfee9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698