Fix PPAPINaClNewlibTest.PostMessage flakiness

Fix PPAPINaClNewlibTest.PostMessage flakiness

Previously PPAPINaClNewlibTest.PostMessage SendInInit was flaking. The problem seems to be that the messages that are sent in Init() may be replied to and handled in HandleMessage() before RunTests() is run (Init() and RunTests() are called asynchronously). When this is the case, WaitForMessages() can return 0, even though the message from Init() is properly received, because the value of message_data_.size() is 1 before and after the function returns. There is actually no need to check the return value of this function, checking the size of message_data_.size() (which we already do) should be sufficient.

BUG=372630
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272542

[dmichael (off chromium), 2014-05-23 15:29:22]

lgtm, nice catch!

[dmichael (off chromium), 2014-05-23 15:29:23]

lgtm, nice catch!

[dmichael (off chromium), 2014-05-23 15:29:26]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2014-05-23 15:30:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/raymes@chromium.org/299893002/1

[commit-bot: I haz the power, 2014-05-23 15:56:04]

Change committed as 272542

[raymes, 2014-05-26 01:00:08]

Thanks for landing!


On Sat, May 24, 2014 at 1:56 AM, <commit-bot@chromium.org> wrote:

> Change committed as 272542
>
> https://codereview.chromium.org/299893002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.