ppapi/tests/test_post_message.cc - Issue 299893002: Fix PPAPINaClNewlibTest.PostMessage flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/tests/test_post_message.cc

Issue 299893002: Fix PPAPINaClNewlibTest.PostMessage flakiness (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/tests/test_post_message.cc

diff --git a/ppapi/tests/test_post_message.cc b/ppapi/tests/test_post_message.cc

index f51cf4e958175393ed29c213d38ed8f17ebfc037..5413b54f00b759f5fe9ed7889bcd80cffa0c6807 100644

--- a/ppapi/tests/test_post_message.cc

+++ b/ppapi/tests/test_post_message.cc

@@ -311,7 +311,8 @@ std::string TestPostMessage::CheckMessageProperties(

}

std::string TestPostMessage::TestSendInInit() {

- ASSERT_EQ(1, WaitForMessages());

+ // Wait for the messages from Init() to be guaranteed to be sent.

+ WaitForMessages();

// This test assumes Init already sent a message.

ASSERT_EQ(1, message_data_.size());

ASSERT_TRUE(message_data_.back().is_string());

« no previous file with comments | « chrome/test/ppapi/ppapi_browsertest.cc ('k') | no next file » | no next file with comments »