Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Unified Diff: telemetry/telemetry/page/page_run_end_to_end_unittest.py

Issue 2998773002: [Telemetry] Reuse shared state between story runs (Closed)
Patch Set: fix unittest Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/page/page_run_end_to_end_unittest.py
diff --git a/telemetry/telemetry/page/page_run_end_to_end_unittest.py b/telemetry/telemetry/page/page_run_end_to_end_unittest.py
index 6f041398f69344708999bf5448114474e3eb86a8..58ab543faaf99c706df514cbc3ada6ed13815240 100644
--- a/telemetry/telemetry/page/page_run_end_to_end_unittest.py
+++ b/telemetry/telemetry/page/page_run_end_to_end_unittest.py
@@ -171,8 +171,7 @@ class ActualPageRunEndToEndTests(unittest.TestCase):
SetUpStoryRunnerArguments(options)
results = results_options.CreateResults(EmptyMetadataForTest(), options)
story_runner.Run(
- test, story_set, options, results, tear_down_after_story=True,
- metadata=EmptyMetadataForTest())
+ test, story_set, options, results, metadata=EmptyMetadataForTest())
self.assertEquals(2, len(GetSuccessfulPageRuns(results)))
self.assertEquals(2, test.browser_starts)
self.assertFormattedExceptionIsEmpty()
@@ -378,8 +377,9 @@ class ActualPageRunEndToEndTests(unittest.TestCase):
class TestSharedState(shared_page_state.SharedPageState):
def _StopBrowser(self):
+ if self._browser:
+ num_times_browser_closed[0] += 1
super(TestSharedState, self)._StopBrowser()
- num_times_browser_closed[0] += 1
story_set = story.StorySet()
page = page_module.Page(
« no previous file with comments | « telemetry/telemetry/internal/story_runner_unittest.py ('k') | telemetry/telemetry/page/shared_page_state.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698