Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: telemetry/telemetry/internal/story_runner_unittest.py

Issue 2998773002: [Telemetry] Reuse shared state between story runs (Closed)
Patch Set: fix unittest Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/story_runner_unittest.py
diff --git a/telemetry/telemetry/internal/story_runner_unittest.py b/telemetry/telemetry/internal/story_runner_unittest.py
index 0496b603efd676857088c0e92d061fbd59bf458e..f50a425966a0887d4c68c11c4ac45b0ffd9379c5 100644
--- a/telemetry/telemetry/internal/story_runner_unittest.py
+++ b/telemetry/telemetry/internal/story_runner_unittest.py
@@ -423,39 +423,6 @@ class StoryRunnerTest(unittest.TestCase):
calls_in_order = GetCallsInOrder() # pylint: disable=no-value-for-parameter
self.assertEquals(EXPECTED_CALLS_IN_ORDER, calls_in_order)
- def testTearDownStateAfterEachStoryOrStorySetRun(self):
- class TestSharedStateForTearDown(TestSharedState):
- num_of_tear_downs = 0
-
- def RunStory(self, results):
- pass
-
- def TearDownState(self):
- TestSharedStateForTearDown.num_of_tear_downs += 1
-
- story_set = story_module.StorySet()
- story_set.AddStory(DummyLocalStory(TestSharedStateForTearDown, name='foo'))
- story_set.AddStory(DummyLocalStory(TestSharedStateForTearDown, name='bar'))
- story_set.AddStory(DummyLocalStory(TestSharedStateForTearDown, name='baz'))
-
- TestSharedStateForTearDown.num_of_tear_downs = 0
- story_runner.Run(mock.MagicMock(), story_set, self.options, self.results,
- metadata=EmptyMetadataForTest())
- self.assertEquals(TestSharedStateForTearDown.num_of_tear_downs, 1)
-
- TestSharedStateForTearDown.num_of_tear_downs = 0
- story_runner.Run(mock.MagicMock(), story_set, self.options, self.results,
- tear_down_after_story=True,
- metadata=EmptyMetadataForTest())
- self.assertEquals(TestSharedStateForTearDown.num_of_tear_downs, 3)
-
- self.options.pageset_repeat = 5
- TestSharedStateForTearDown.num_of_tear_downs = 0
- story_runner.Run(mock.MagicMock(), story_set, self.options, self.results,
- tear_down_after_story_set=True,
- metadata=EmptyMetadataForTest())
- self.assertEquals(TestSharedStateForTearDown.num_of_tear_downs, 5)
-
def testAppCrashExceptionCausesFailureValue(self):
self.SuppressExceptionFormatting()
story_set = story_module.StorySet()
« no previous file with comments | « telemetry/telemetry/internal/story_runner.py ('k') | telemetry/telemetry/page/page_run_end_to_end_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698