Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2998703002: Handle creation of class members in files other than the file containing the error (issue 30327) (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle creation of class members in files other than the file containing the error R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/beae4b29f128c178cd786a974ac6c9d45c66d5a4

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 3 chunks +22 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 2 chunks +36 lines, -1 line 2 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 4 months ago (2017-08-09 15:44:49 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2998703002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart File pkg/analysis_server/test/services/correction/fix_test.dart (right): https://codereview.chromium.org/2998703002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart#newcode1635 pkg/analysis_server/test/services/correction/fix_test.dart:1635: test_createField_getter_qualified_instance_differentLibrary() async { There were two changes - ...
3 years, 4 months ago (2017-08-09 15:52:07 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2998703002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart File pkg/analysis_server/test/services/correction/fix_test.dart (right): https://codereview.chromium.org/2998703002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart#newcode1635 pkg/analysis_server/test/services/correction/fix_test.dart:1635: test_createField_getter_qualified_instance_differentLibrary() async { Not the way the code is ...
3 years, 4 months ago (2017-08-09 15:56:33 UTC) #4
Brian Wilkerson
3 years, 4 months ago (2017-08-09 15:57:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
beae4b29f128c178cd786a974ac6c9d45c66d5a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698