Handle creation of class members in files other than the file containing the error (issue 30327)

pkg/analysis_server/test/services/correction/fix_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analysis_server/plugin/edit/fix/fix_core.dart';
 import 'package:analysis_server/plugin/edit/fix/fix_dart.dart';
 import 'package:analysis_server/src/services/correction/fix.dart';
 import 'package:analysis_server/src/services/correction/fix_internal.dart';
@@ skipping 67 matching lines @@
 
   assertHasFix(FixKind kind, String expected, {String target}) async {
     AnalysisError error = await _findErrorToFix();
     fix = await _assertHasFix(kind, error);
     change = fix.change;
 
     // apply to "file"
     List<SourceFileEdit> fileEdits = change.edits;
     expect(fileEdits, hasLength(1));
 
+    String fileContent = testCode;
     if (target != null) {
       expect(target, fileEdits.first.file);
+      fileContent = provider.getFile(target).readAsStringSync();
     }
 
-    resultCode = SourceEdit.applySequence(testCode, change.edits[0].edits);
+    resultCode = SourceEdit.applySequence(fileContent, change.edits[0].edits);
     // verify
     expect(resultCode, expected);
   }
 
   assertNoFix(FixKind kind) async {
     AnalysisError error = await _findErrorToFix();
     List<Fix> fixes = await _computeFixes(error);
     for (Fix fix in fixes) {
       if (fix.kind == kind) {
         throw fail('Unexpected fix $kind in\n${fixes.join('\n')}');
@@ skipping 1520 matching lines @@
     await assertHasFix(DartFixKind.CREATE_FIELD, '''
 class A {
   int test;
 }
 main(A a) {
   int v = a.test;
 }
 ''');
   }
 
+  test_createField_getter_qualified_instance_differentLibrary() async {

[scheglov, 2017/08/09 15:52:07]

There were two changes - for fields and for getters.
This one tests fields.
Do we need another test for getters?

[Brian Wilkerson, 2017/08/09 15:56:33]

Not the way the code is currently written, but I've added it in case the code
changes.

+    addSource('/other.dart', '''
+/**
+ * A comment to push the offset of the braces for the following class
+ * declaration past the end of the content of the test file. Used to catch an
+ * index out of bounds exception that occurs when using the test source instead
+ * of the target source to compute the location at which to insert the field.
+ */
+class A {
+}
+''');
+    await resolveTestUnit('''
+import 'other.dart';
+main(A a) {
+  int v = a.test;
+}
+''');
+    await assertHasFix(
+        DartFixKind.CREATE_FIELD,
+        '''
+/**
+ * A comment to push the offset of the braces for the following class
+ * declaration past the end of the content of the test file. Used to catch an
+ * index out of bounds exception that occurs when using the test source instead
+ * of the target source to compute the location at which to insert the field.
+ */
+class A {
+  int test;
+}
+''',
+        target: '/other.dart');
+  }
+
   test_createField_getter_qualified_instance_dynamicType() async {
     await resolveTestUnit('''
 class A {
   B b;
   void f(Object p) {
     p == b.test;
   }
 }
 class B {
 }
@@ skipping 4770 matching lines @@
   @override
   final AnalysisError error;
 
   _DartFixContextImpl(this.resourceProvider, this.analysisDriver,
       this.astProvider, this.unit, this.error);
 
   @override
   GetTopLevelDeclarations get getTopLevelDeclarations =>
       analysisDriver.getTopLevelNameDeclarations;
 }