Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/browser/admin_policy.cc

Issue 299853002: Make installed_loader UMA less wasteful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/installed_loader.cc ('K') | « chrome/common/extensions/sync_helper.cc ('k') | extensions/browser/extension_web_contents_observer.cc » ('j') | extensions/common/manifest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/admin_policy.cc
diff --git a/extensions/browser/admin_policy.cc b/extensions/browser/admin_policy.cc
index 574deff0022681c4ebc27abdbeb4f021675bb7fa..6ab947d92f887b6348147cfc7a824d865186b83b 100644
--- a/extensions/browser/admin_policy.cc
+++ b/extensions/browser/admin_policy.cc
@@ -93,12 +93,15 @@ bool UserMayLoad(const base::ListValue* blacklist,
case Manifest::TYPE_HOSTED_APP:
case Manifest::TYPE_LEGACY_PACKAGED_APP:
case Manifest::TYPE_PLATFORM_APP:
- case Manifest::TYPE_SHARED_MODULE:
+ case Manifest::TYPE_SHARED_MODULE: {
base::FundamentalValue type_value(extension->GetType());
if (allowed_types &&
allowed_types->Find(type_value) == allowed_types->end())
return ReturnLoadError(extension, error);
break;
Devlin 2014/05/21 19:54:09 Hey, this break statement actually does something
+ }
+ case Manifest::NUM_LOAD_TYPES:
+ NOTREACHED();
}
// Check the whitelist/forcelist first.
« chrome/browser/extensions/installed_loader.cc ('K') | « chrome/common/extensions/sync_helper.cc ('k') | extensions/browser/extension_web_contents_observer.cc » ('j') | extensions/common/manifest.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698