Make installed_loader UMA less wasteful.

extensions/browser/admin_policy.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/admin_policy.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest.h"
 #include "grit/extensions_strings.h"
@@ skipping 75 matching lines @@
   // kExtensionAllowedTypesMap in configuration_policy_handler_list.cc.
   switch (extension->GetType()) {
     case Manifest::TYPE_UNKNOWN:
       break;
     case Manifest::TYPE_EXTENSION:
     case Manifest::TYPE_THEME:
     case Manifest::TYPE_USER_SCRIPT:
     case Manifest::TYPE_HOSTED_APP:
     case Manifest::TYPE_LEGACY_PACKAGED_APP:
     case Manifest::TYPE_PLATFORM_APP:
-    case Manifest::TYPE_SHARED_MODULE:
+    case Manifest::TYPE_SHARED_MODULE: {
       base::FundamentalValue type_value(extension->GetType());
       if (allowed_types &&
           allowed_types->Find(type_value) == allowed_types->end())
         return ReturnLoadError(extension, error);
       break;

[Devlin, 2014/05/21 19:54:09]

Hey, this break statement actually does something now! ;)

+    }
+    case Manifest::NUM_LOAD_TYPES:
+      NOTREACHED();
   }
 
   // Check the whitelist/forcelist first.
   base::StringValue id_value(extension->id());
   if ((whitelist && whitelist->Find(id_value) != whitelist->end()) ||
       (forcelist && forcelist->HasKey(extension->id())))
     return true;
 
   // Then check the admin blacklist.
   if ((blacklist && blacklist->Find(id_value) != blacklist->end()) ||
       BlacklistedByDefault(blacklist))
     return ReturnLoadError(extension, error);
 
   return true;
 }
 
 bool UserMayModifySettings(const Extension* extension, base::string16* error) {
   return ManagementPolicyImpl(extension, error, true);
 }
 
 bool MustRemainEnabled(const Extension* extension, base::string16* error) {
   return ManagementPolicyImpl(extension, error, false);
 }
 
 }  // namespace admin_policy
 }  // namespace extensions