tools/gn.py - Issue 2998503002: Change defaults for build args to accommodate Flutter and Fuchsia.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn.py

Issue 2998503002: Change defaults for build args to accommodate Flutter and Fuchsia. (Closed)

Patch Set: Add comment Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn.py

diff --git a/tools/gn.py b/tools/gn.py

index 91defcdcbbb5b79f6e4e3ef6c110dab580cad4f3..fe22ba46650255a53aa244ced264c963e21bd9b3 100755

--- a/tools/gn.py

+++ b/tools/gn.py

@@ -223,7 +223,9 @@ def ToGnArgs(args, mode, arch, target_os):

gn_args['is_msan'] = args.msan and gn_args['is_clang']

gn_args['is_tsan'] = args.tsan and gn_args['is_clang']

- gn_args['dart_platform_sdk'] = args.platform_sdk

+ if not args.platform_sdk and not gn_args['target_cpu'].startswith('arm'):

+ gn_args['dart_platform_sdk'] = args.platform_sdk

+ gn_args['dart_stripped_binary'] = 'exe.stripped/dart'

# Setup the user-defined sysroot.

if gn_args['target_os'] == 'linux' and args.wheezy and not crossbuild:

« no previous file with comments | « sdk/BUILD.gn ('k') | no next file » | no next file with comments »