Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: sdk/BUILD.gn

Issue 2998503002: Change defaults for build args to accommodate Flutter and Fuchsia. (Closed)
Patch Set: Add comment Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/BUILD.gn
diff --git a/sdk/BUILD.gn b/sdk/BUILD.gn
index f0458053bb42a589eb986a7194cb2190cf9943b4..6ec91aeaba7524ef29cd30ff56dd321f3b11d584 100644
--- a/sdk/BUILD.gn
+++ b/sdk/BUILD.gn
@@ -17,14 +17,9 @@ import("../build/copy_tree.gni")
declare_args() {
# Build a SDK with less stuff. It excludes dart2js, ddc, and web libraries.
- dart_platform_sdk = false
-}
-
-if (is_fuchsia ||
- is_fuchsia_host ||
- current_cpu == "arm64" ||
- current_cpu == "arm") {
dart_platform_sdk = true
+ # Path to stripped dart binary relative to build output directory.
+ dart_stripped_binary = "dart"
}
# The directory layout of the SDK is as follows:
@@ -226,13 +221,9 @@ copy("copy_dart") {
sources = [
"$dart_out/dart.exe",
]
- } else if (is_fuchsia || is_fuchsia_host) {
- sources = [
- "$dart_out/dart",
- ]
} else {
sources = [
- "$dart_out/exe.stripped/dart",
+ "$dart_out/$dart_stripped_binary"
]
}
if (is_win) {
« no previous file with comments | « no previous file | tools/gn.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698