Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2998463002: Revert of Always set the navigation pending item for page reload. (Closed)

Created:
3 years, 4 months ago by mrefaat
Modified:
3 years, 4 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Always set the navigation pending item for page reload. (patchset #6 id:220001 of https://codereview.chromium.org/2931833004/ ) Reason for revert: introduced crbug/750775 Original issue's description: > Always set the navigation pending item for page reload. > > Set the pendingItemIndex to the last committed item in case of page reload > and on the case of application open/tab out of memory reopened. > > This doesn't solve the PendingItem being null problem entirely there are still > couple cases when that can happen and they are not page reloads. > > CL 1/2 > > BUG=676129 > > Review-Url: https://codereview.chromium.org/2931833004 > Cr-Commit-Position: refs/heads/master@{#486777} > Committed: https://chromium.googlesource.com/chromium/src/+/bc2e0a45e23c739bb3c04d119d43abbb01398289 TBR=eugenebut@chromium.org,kkhorimoto@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=676129 Review-Url: https://codereview.chromium.org/2998463002 Cr-Commit-Position: refs/heads/master@{#492138} Committed: https://chromium.googlesource.com/chromium/src/+/d7d7325907b8c0920e7a8705f5df9f17432ae1c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -26 lines) Patch
M ios/web/web_state/navigation_callbacks_inttest.mm View 2 chunks +12 lines, -5 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 3 chunks +5 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mrefaat
Created Revert of Always set the navigation pending item for page reload.
3 years, 4 months ago (2017-08-04 18:45:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2998463002/1
3 years, 4 months ago (2017-08-04 18:45:46 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 4 months ago (2017-08-04 18:45:49 UTC) #5
Eugene But (OOO till 7-30)
lgtm
3 years, 4 months ago (2017-08-04 20:11:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2998463002/1
3 years, 4 months ago (2017-08-04 21:40:17 UTC) #8
commit-bot: I haz the power
3 years, 4 months ago (2017-08-04 22:01:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d7d7325907b8c0920e7a8705f5df...

Powered by Google App Engine
This is Rietveld 408576698