Issue 299813002: Revert "Fix Heap::IsHeapIterable." (again)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299813002: Revert "Fix Heap::IsHeapIterable." (again) (Closed)

Created:
6 years, 7 months ago by Jarin

Modified:
6 years, 7 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Fix Heap::IsHeapIterable." (again) This reverts commit r21397. TBR=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21404

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -85 lines)			Patch
M	src/debug.cc	View	5 chunks	+7 lines, -2 lines	0 comments	Download
M	src/heap.h	View	3 chunks	+1 line, -10 lines	0 comments	Download
M	src/heap.cc	View	3 chunks	+5 lines, -10 lines	0 comments	Download
M	src/heap-profiler.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/heap-snapshot-generator.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/liveedit.cc	View	7 chunks	+14 lines, -8 lines	0 comments	Download
M	src/runtime.cc	View	7 chunks	+40 lines, -36 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	test/cctest/test-object-observe.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	test/mjsunit/regress/regress-373283.js	View	1 chunk	+0 lines, -18 lines	0 comments	Download

Total messages: 1 (0 generated)

Jarin

6 years, 7 months ago (2014-05-21 09:49:29 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r21404 (presubmit successful).