src/heap-snapshot-generator.cc - Issue 299813002: Revert "Fix Heap::IsHeapIterable." (again)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-snapshot-generator.cc

Issue 299813002: Revert "Fix Heap::IsHeapIterable." (again) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap-snapshot-generator.cc

diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc

index ef752ff20d96fe3aa611fcbfbd54e6130feed54d..cafee77b4ce10d20be74ee3df7fe290349cff63f 100644

--- a/src/heap-snapshot-generator.cc

+++ b/src/heap-snapshot-generator.cc

@@ -2569,6 +2569,10 @@ bool HeapSnapshotGenerator::GenerateSnapshot() {

CHECK(!debug_heap->map_space()->was_swept_conservatively());

#endif

+ // The following code uses heap iterators, so we want the heap to be

+ // stable. It should follow TagGlobalObjects as that can allocate.

+ DisallowHeapAllocation no_alloc;

#ifdef VERIFY_HEAP

debug_heap->Verify();

#endif

« no previous file with comments | « src/heap-profiler.cc ('k') | src/liveedit.cc » ('j') | no next file with comments »