Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2998063002: VideoProcessor: mini-fixes in preparation for task queue CL. (Closed)

Created:
3 years, 4 months ago by brandtr
Modified:
3 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoProcessor: mini-fixes in preparation for task queue CL. * Make ProcessFrame return void. * Make |encode_callback_| and |decode_callback_| direct members. * Remove ::EncodedFrameSize() and ::EncodedFrameType() * Remove unused |timestamp| member from FrameInfo. * Reorder printf output from PrintCodecSettings. * Make some member functions const. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2998063002 Cr-Commit-Position: refs/heads/master@{#19421} Committed: https://chromium.googlesource.com/external/webrtc/+/bdd555c7a7bc06e98f7914bbbcaa10fd764adecf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -108 lines) Patch
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 7 chunks +26 lines, -46 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 9 chunks +45 lines, -53 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 4 chunks +8 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
brandtr
3 years, 4 months ago (2017-08-18 13:42:22 UTC) #2
åsapersson
lgtm
3 years, 4 months ago (2017-08-21 07:23:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2998063002/1
3 years, 4 months ago (2017-08-21 07:26:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/26725)
3 years, 4 months ago (2017-08-21 08:00:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2998063002/1
3 years, 4 months ago (2017-08-21 08:20:31 UTC) #9
commit-bot: I haz the power
3 years, 4 months ago (2017-08-21 08:34:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/bdd555c7a7bc06e98f7914bbb...

Powered by Google App Engine
This is Rietveld 408576698