Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2998053002: Fix unnecessary use of this.length in ListMixin. (Closed)

Created:
3 years, 4 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 3 months ago
Reviewers:
Leaf, floitsch
CC:
reviews_dartlang.org, Leaf
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix unnecessary use of this.length in ListMixin. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/lib/collection/list.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Lasse Reichstein Nielsen
3 years, 4 months ago (2017-08-18 11:58:33 UTC) #2
floitsch
LGTM.
3 years, 4 months ago (2017-08-18 12:01:05 UTC) #3
Leaf
Thanks!
3 years, 4 months ago (2017-08-18 16:10:46 UTC) #5
Lasse Reichstein Nielsen
3 years, 3 months ago (2017-08-24 07:57:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0194b3473df4c8d6a838306fd82f919ab78a034f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698