Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2997903002: WIP TQ (Closed)

Created:
3 years, 4 months ago by brandtr
Modified:
3 years, 4 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

WIP TQ fixups * Reorganize function calls in videoprocessor_integrationtest.cc * Move QP verification. * Remove EncodedFrameSize and EncodedFrameType. * Split up processing and rate control calculations. * Change frame number accounting. => This changes the output results a little bit! * Simplify rate setting for the local accounting. * Rename methods: SetUpObjects -> SetUpAndInitObjects. * Make VerifyQuality and NumberOfTemporalLayer static. * Make quality and rate control thresholds optional. * Remove batch mode. * Visualization file names shortened. ::ReleaseAndCloseObjects() More improvements to VideoProcessor. * Add sequenced task checker. * Let ProcessFrame return void. * Make |encode_callback_| and |decode_callback_| direct members. * Remove unused |timestamp| from FrameInfo struct. * Reorder output from PrintCodecSettings. * Extend unit tests. BUG=

Patch Set 1 #

Patch Set 2 : Make member functions const. #

Patch Set 3 : Fix GN. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+719 lines, -560 lines) Patch
M webrtc/modules/video_coding/BUILD.gn View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 4 chunks +9 lines, -32 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 1 2 5 chunks +101 lines, -71 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 1 12 chunks +80 lines, -60 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 2 22 chunks +261 lines, -195 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 12 chunks +164 lines, -185 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_unittest.cc View 5 chunks +96 lines, -14 lines 0 comments Download
M webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (9 generated)
brandtr
The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run
3 years, 4 months ago (2017-08-16 15:12:24 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997903002/20001
3 years, 4 months ago (2017-08-16 15:12:31 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-16 15:15:23 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_tsan2 on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/24965) mac_asan on ...
3 years, 4 months ago (2017-08-16 15:15:24 UTC) #4
brandtr
The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run
3 years, 4 months ago (2017-08-16 15:20:10 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997903002/40001
3 years, 4 months ago (2017-08-16 15:20:21 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-16 15:26:11 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20247)
3 years, 4 months ago (2017-08-16 15:26:12 UTC) #8
brandtr
3 years, 4 months ago (2017-08-17 07:32:17 UTC) #9 
Description was changed from

==========
WIP TQ


fixups


* Reorganize function calls in videoprocessor_integrationtest.cc


* Move QP verification.


* Remove EncodedFrameSize and EncodedFrameType.


* Split up processing and rate control calculations.


* Change frame number accounting.

=> This changes the output results a little bit!

* Simplify rate setting for the local accounting.


* Rename methods: SetUpObjects -> SetUpAndInitObjects. * Make VerifyQuality and
NumberOfTemporalLayer static.


* Make quality and rate control thresholds optional.


* Remove batch mode.


* Visualization file names shortened.


::ReleaseAndCloseObjects()


More improvements to VideoProcessor.

* Add sequenced task checker.
* Let ProcessFrame return void.
* Make |encode_callback_| and |decode_callback_| direct members.
* Remove unused |timestamp| from FrameInfo struct.
* Reorder output from PrintCodecSettings.
* Extend unit tests.

BUG=
==========

to

==========
WIP TQ


fixups


* Reorganize function calls in videoprocessor_integrationtest.cc


* Move QP verification.


* Remove EncodedFrameSize and EncodedFrameType.


* Split up processing and rate control calculations.


* Change frame number accounting.

=> This changes the output results a little bit!

* Simplify rate setting for the local accounting.


* Rename methods: SetUpObjects -> SetUpAndInitObjects. * Make VerifyQuality and
NumberOfTemporalLayer static.


* Make quality and rate control thresholds optional.


* Remove batch mode.


* Visualization file names shortened.


::ReleaseAndCloseObjects()


More improvements to VideoProcessor.

* Add sequenced task checker.
* Let ProcessFrame return void.
* Make |encode_callback_| and |decode_callback_| direct members.
* Remove unused |timestamp| from FrameInfo struct.
* Reorder output from PrintCodecSettings.
* Extend unit tests.

BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698