Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2997853002: Change ThreadChecker to SequencedTaskChecker in VideoReceiveStream (Closed)

Created:
3 years, 4 months ago by eladalon
Modified:
3 years, 4 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change ThreadChecker to SequencedTaskChecker in VideoReceiveStream In preparation of running DirectTransport on a TaskQueue in unit-tests, change the thread-checkers to sequence-checkers. This is necessary for Mac and iOS, where the TaskQueue is guaranteed to run sequentially, but not guaranteed to do so on only one thread. TODO: Add the relevant BUGs. BUG=None Review-Url: https://codereview.webrtc.org/2997853002 Cr-Commit-Position: refs/heads/master@{#19408} Committed: https://chromium.googlesource.com/external/webrtc/+/a28122f5cdd4c21c5674297e2cce14c8da15f9bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M webrtc/video/video_receive_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 7 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
tommi
lgtm
3 years, 4 months ago (2017-08-18 08:18:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997853002/1
3 years, 4 months ago (2017-08-18 10:36:58 UTC) #4
commit-bot: I haz the power
3 years, 4 months ago (2017-08-18 11:02:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a28122f5cdd4c21c5674297e2...

Powered by Google App Engine
This is Rietveld 408576698