Revert of Plumb SparseDiagnostics by Name

Revert of Plumb SparseDiagnostics by Name (patchset #7 id:120001 of https://codereview.chromium.org/2989143002/ )

Reason for revert:
This CL landed while adding tests that used functionality that was deprecated by a separate CL

Original issue's description:
> Plumb SparseDiagnostics by Name
> 
> This CL adds the creation of Sparse Diagnostics in add_histograms by using
> a set of reserved names.
> 
> It also adds some of the logic so that when shared diagnostics of histograms
> are imported, their name is checked against the reserved set, instead of 
> only using their type.
> 
> This addresses step 5 of the list of tasks to be done in bug 3507.
> 
> 
> BUG=catapult:#3718, catapult:#3507
> 
> Review-Url: https://codereview.chromium.org/2989143002
> Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/68c8e443039c742d3685516647cfef77def67d27

TBR=eakuefner@chromium.org,benjhayden@chromium.org,simonhatch@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=catapult:#3718, catapult:#3507

Review-Url: https://codereview.chromium.org/2997643002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f62d597f2ef814d043cdc089b23989253579c0e8

[phsilva, 2017-08-09 01:15:39]

The CQ bit was checked by phsilva@google.com

[phsilva, 2017-08-09 01:15:46]

Created Revert of Plumb SparseDiagnostics by Name

[commit-bot: I haz the power, 2017-08-09 01:15:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-09 01:15:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-09 01:15:58]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-catapult-committers".
Note that this has nothing to do with OWNERS files.

[nednguyen, 2017-08-09 01:17:28]

nednguyen@google.com changed reviewers:
+ nednguyen@google.com

[nednguyen, 2017-08-09 01:17:29]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2017-08-09 01:17:29]

lgtm

[commit-bot: I haz the power, 2017-08-09 01:17:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-09 01:17:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1502241449034370, "parent_rev":
"4b5cb18a5295dbf245d305deb124c469ed229a7c", "commit_rev":
"f62d597f2ef814d043cdc089b23989253579c0e8"}

[commit-bot: I haz the power, 2017-08-09 01:17:41]

Description was changed from

==========
Revert of Plumb SparseDiagnostics by Name (patchset #7 id:120001 of
https://codereview.chromium.org/2989143002/ )

Reason for revert:
This CL landed while adding tests that used functionality that was deprecated by
a separate CL

Original issue's description:
> Plumb SparseDiagnostics by Name
> 
> This CL adds the creation of Sparse Diagnostics in add_histograms by using
> a set of reserved names.
> 
> It also adds some of the logic so that when shared diagnostics of histograms
> are imported, their name is checked against the reserved set, instead of 
> only using their type.
> 
> This addresses step 5 of the list of tasks to be done in bug 3507.
> 
> 
> BUG=catapult:#3718, catapult:#3507
> 
> Review-Url: https://codereview.chromium.org/2989143002
> Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

TBR=eakuefner@chromium.org,benjhayden@chromium.org,simonhatch@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=catapult:#3718, catapult:#3507
==========

to

==========
Revert of Plumb SparseDiagnostics by Name (patchset #7 id:120001 of
https://codereview.chromium.org/2989143002/ )

Reason for revert:
This CL landed while adding tests that used functionality that was deprecated by
a separate CL

Original issue's description:
> Plumb SparseDiagnostics by Name
> 
> This CL adds the creation of Sparse Diagnostics in add_histograms by using
> a set of reserved names.
> 
> It also adds some of the logic so that when shared diagnostics of histograms
> are imported, their name is checked against the reserved set, instead of 
> only using their type.
> 
> This addresses step 5 of the list of tasks to be done in bug 3507.
> 
> 
> BUG=catapult:#3718, catapult:#3507
> 
> Review-Url: https://codereview.chromium.org/2989143002
> Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

TBR=eakuefner@chromium.org,benjhayden@chromium.org,simonhatch@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=catapult:#3718, catapult:#3507

Review-Url: https://codereview.chromium.org/2997643002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-08-09 01:17:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...