Replace comment style generic method syntax with real syntax (TBR)

Replace comment style generic method syntax with real syntax

Committed: https://github.com/dart-lang/sdk/commit/01b024c00655591c063f52a593774bbbac95cc86

[Brian Wilkerson, 2017-08-08 17:33:48]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com, sra@google.com

[Brian Wilkerson, 2017-08-08 17:33:48]

We started producing a hint for the old syntax, which broke a couple of bots.
This cleans up the uses of the old syntax and should have zero impact on the
code.

[Brian Wilkerson, 2017-08-08 17:34:13]

Description was changed from

==========
Replace comment style generic method syntax with real syntax
==========

to

==========
Replace comment style generic method syntax with real syntax

Committed:
https://github.com/dart-lang/sdk/commit/01b024c00655591c063f52a593774bbbac95cc86
==========

[Brian Wilkerson, 2017-08-08 17:34:15]

Committed patchset #1 (id:1) manually as
01b024c00655591c063f52a593774bbbac95cc86 (presubmit successful).

[scheglov, 2017-08-08 17:36:02]

LGTM

[sra1, 2017-08-08 17:53:20]

sra@google.com changed reviewers:
+ johnniwinther@google.com

[sra1, 2017-08-08 17:53:21]

Probably best to split the dart2js edits into another CL.

The dart2js code is in transition and had been touched recently - we would not
have the /*T*/ syntax without good reason.

I'd say lgtm only if both of these tests pass:

tools/test.py -m release \
       -c dart2js -r d8 --dart2js-batch --report \
       --host-checked \
       language corelib library_2 corelib_2 \
       dart2js_native dart2js_extra


tools/test.py -m release \
       -c dart2js -r d8 --dart2js-batch --report \
       --dart2js-with-kernel --host-checked \
       --dart2js_options="--library-root=out/ReleaseX64/dart-sdk/" \
       language corelib library_2 corelib_2 \
       dart2js_native dart2js_extra

[Brian Wilkerson, 2017-08-08 18:07:33]

I can revert if necessary, but the new hint produced when the old syntax is
being used will necessitate skipping running analyzer over dart2js on the bots
if these changes can't be made. (If there's a reason we can't / shouldn't enable
the hint at this point, please let me know that too.)

[Brian Wilkerson, 2017-08-08 19:46:38]

For the record, I ran the tests and they both passed.