Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: pkg/compiler/lib/src/kernel/element_map_impl.dart

Issue 2997593002: Replace comment style generic method syntax with real syntax (TBR) (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/task/model.dart ('k') | pkg/compiler/lib/src/ssa/interceptor_simplifier.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/kernel/element_map_impl.dart
diff --git a/pkg/compiler/lib/src/kernel/element_map_impl.dart b/pkg/compiler/lib/src/kernel/element_map_impl.dart
index 0ea848812b398acbfc04acced7577e27559a234f..a6520a0b91f0d4fd399a0ba4e569d05ede175baf 100644
--- a/pkg/compiler/lib/src/kernel/element_map_impl.dart
+++ b/pkg/compiler/lib/src/kernel/element_map_impl.dart
@@ -251,18 +251,18 @@ abstract class KernelToElementMapBase extends KernelToElementMapBaseMixin {
// no longer use resolution types.
if (node.typeParameters.isEmpty) {
data.thisType =
- data.rawType = new InterfaceType(cls, const/*<DartType>*/ []);
+ data.rawType = new InterfaceType(cls, const <DartType>[]);
} else {
data.thisType = new InterfaceType(
cls,
- new List/*<DartType>*/ .generate(node.typeParameters.length,
+ new List<DartType>.generate(node.typeParameters.length,
(int index) {
return new TypeVariableType(
_getTypeVariable(node.typeParameters[index]));
}));
data.rawType = new InterfaceType(
cls,
- new List/*<DartType>*/ .filled(
+ new List<DartType>.filled(
node.typeParameters.length, const DynamicType()));
}
}
@@ -397,7 +397,7 @@ abstract class KernelToElementMapBase extends KernelToElementMapBaseMixin {
List<DartType> getDartTypes(List<ir.DartType> types) {
// TODO(johnniwinther): Add the type argument to the list literal when we
// no longer use resolution types.
- List<DartType> list = /*<DartType>*/ [];
+ List<DartType> list = <DartType>[];
types.forEach((ir.DartType type) {
list.add(getDartType(type));
});
@@ -418,8 +418,8 @@ abstract class KernelToElementMapBase extends KernelToElementMapBaseMixin {
} else {
returnType = getDartType(node.returnType);
}
- List<DartType> parameterTypes = /*<DartType>*/ [];
- List<DartType> optionalParameterTypes = /*<DartType>*/ [];
+ List<DartType> parameterTypes = <DartType>[];
+ List<DartType> optionalParameterTypes = <DartType>[];
for (ir.VariableDeclaration variable in node.positionalParameters) {
if (parameterTypes.length == node.requiredParameterCount) {
optionalParameterTypes.add(getDartType(variable.type));
@@ -428,7 +428,7 @@ abstract class KernelToElementMapBase extends KernelToElementMapBaseMixin {
}
}
List<String> namedParameters = <String>[];
- List<DartType> namedParameterTypes = /*<DartType>*/ [];
+ List<DartType> namedParameterTypes = <DartType>[];
List<ir.VariableDeclaration> sortedNamedParameters =
node.namedParameters.toList()..sort((a, b) => a.name.compareTo(b.name));
for (ir.VariableDeclaration variable in sortedNamedParameters) {
@@ -1999,7 +1999,7 @@ class JsKernelToElementMap extends KernelToElementMapBase
closureData
..isMixinApplication = false
..thisType =
- closureData.rawType = new InterfaceType(cls, const/*<DartType>*/ [])
+ closureData.rawType = new InterfaceType(cls, const <DartType>[])
..supertype = supertype
..interfaces = const <InterfaceType>[];
var setBuilder = new _KernelOrderedTypeSetBuilder(this, cls);
« no previous file with comments | « pkg/analyzer/lib/task/model.dart ('k') | pkg/compiler/lib/src/ssa/interceptor_simplifier.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698