Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 299753007: Make find_runtime_tools available for non-Chrome executables. (Closed)

Created:
6 years, 7 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
6 years, 3 months ago
Reviewers:
hajimehoshi, wensheng
CC:
chromium-reviews, dmikurube+memory_chromium.org
Visibility:
Public.

Description

Make find_runtime_tools available for non-Chrome executables. BUG=123750 TEST=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271872

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M tools/find_runtime_symbols/prepare_symbol_info.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/linux/procfs.py View 2 chunks +7 lines, -10 lines 2 comments Download
M tools/linux/tests/procfs_tests.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Dai Mikurube (NOT FULLTIME)
Hoshi-san, It'd make dmprof work for content_shell. Could you rubber-stamp it?
6 years, 7 months ago (2014-05-21 08:13:36 UTC) #1
hajimehoshi
On 2014/05/21 08:13:36, Dai Mikurube wrote: > Hoshi-san, > > It'd make dmprof work for ...
6 years, 7 months ago (2014-05-21 08:21:40 UTC) #2
Dai Mikurube (NOT FULLTIME)
The CQ bit was checked by dmikurube@chromium.org
6 years, 7 months ago (2014-05-21 08:23:44 UTC) #3
Dai Mikurube (NOT FULLTIME)
Thanks!
6 years, 7 months ago (2014-05-21 08:23:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/299753007/1
6 years, 7 months ago (2014-05-21 08:25:16 UTC) #5
commit-bot: I haz the power
Change committed as 271872
6 years, 7 months ago (2014-05-21 08:28:16 UTC) #6
wensheng
https://codereview.chromium.org/299753007/diff/1/tools/linux/procfs.py File tools/linux/procfs.py (right): https://codereview.chromium.org/299753007/diff/1/tools/linux/procfs.py#newcode314 tools/linux/procfs.py:314: r'\S+\.(so|dll|dylib|bundle)((\.\d+)+\w*(\.\d+){0,3})?') Dmprof may not support content shell as the ...
6 years, 3 months ago (2014-08-30 03:29:48 UTC) #8
Dai Mikurube (NOT FULLTIME)
https://codereview.chromium.org/299753007/diff/1/tools/linux/procfs.py File tools/linux/procfs.py (right): https://codereview.chromium.org/299753007/diff/1/tools/linux/procfs.py#newcode314 tools/linux/procfs.py:314: r'\S+\.(so|dll|dylib|bundle)((\.\d+)+\w*(\.\d+){0,3})?') On 2014/08/30 03:29:48, wensheng.he wrote: > Dmprof may ...
6 years, 3 months ago (2014-09-02 15:11:15 UTC) #9
wensheng
6 years, 3 months ago (2014-09-07 07:49:42 UTC) #10
Message was sent while issue was closed.
On 2014/09/02 15:11:15, Dai Mikurube (NOT FULLTIME) wrote:
> https://codereview.chromium.org/299753007/diff/1/tools/linux/procfs.py
> File tools/linux/procfs.py (right):
> 
>
https://codereview.chromium.org/299753007/diff/1/tools/linux/procfs.py#newcod...
> tools/linux/procfs.py:314:
> r'\S+\.(so|dll|dylib|bundle)((\.\d+)+\w*(\.\d+){0,3})?')
> On 2014/08/30 03:29:48, wensheng.he wrote:
> > Dmprof may not support content shell as the modification here, 
> > but when I just try to use dmprof in content shell and the result is that I
> > don't have the same problem (currently I still not merge the bug).
> > At last, I  find out the reason is that my path have the key word chrome:
> >
/home/view/dtv_view/hewensheng/chrome37/src/out_type_nop/Release/content_shell
> > So I think this is not accurate for the matching rule for the pathname in
> > /proc/[pid]/maps. Better to add '$' in the RE here, I think.
> 
> Please take a look in prepare_symbol_info.py. It now accepts any file if the
> file is executable. content_shell is used by this rule.

Sorry, maybe my question is not clear.
The rule to matching the file extension is an absolute path, not exactly the
file name. 
So if the path before the file name already has the key word of the file
extension, e.x, "chrome" or "so",
it will still match the condition. This is not accurate, I think.
The solution I advise is to add '$' in the regular expression, so it will match
the file name exactly.

Powered by Google App Engine
This is Rietveld 408576698