Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/find_runtime_symbols/prepare_symbol_info.py

Issue 299753007: Make find_runtime_tools available for non-Chrome executables. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/linux/procfs.py » ('j') | tools/linux/procfs.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/find_runtime_symbols/prepare_symbol_info.py
diff --git a/tools/find_runtime_symbols/prepare_symbol_info.py b/tools/find_runtime_symbols/prepare_symbol_info.py
index 9bce5455c825f9c6aa48d3561e75912434141202..17d34deaa22b0fca032125ffec44c0e0fd12872d 100755
--- a/tools/find_runtime_symbols/prepare_symbol_info.py
+++ b/tools/find_runtime_symbols/prepare_symbol_info.py
@@ -154,6 +154,9 @@ def prepare_symbol_info(maps_path,
for target_path, host_path in alternative_dirs.iteritems():
if entry.name.startswith(target_path):
binary_path = entry.name.replace(target_path, host_path, 1)
+ if not (ProcMaps.EXECUTABLE_PATTERN.match(binary_path) or
+ (os.path.isfile(binary_path) and os.access(binary_path, os.X_OK))):
+ continue
nm_filename = _dump_command_result(
'nm -n --format bsd %s | c++filt' % binary_path,
output_dir_path, os.path.basename(binary_path), '.nm')
« no previous file with comments | « no previous file | tools/linux/procfs.py » ('j') | tools/linux/procfs.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698