Disable --deoptimize-every/--stacktrace-every in kernel isolate

[VM] Disable --deoptimize-every/--stacktrace-every in kernel isolate

Since the kernel isolate is just an auxiliary service, it makes little sense that it "inherit" these flag (similarly --checked is not "inherited" by kernel isolate)

Fixes https://github.com/dart-lang/sdk/issues/28788
Fixes https://github.com/dart-lang/sdk/issues/28933

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/055dbbfd68235965c35e1101771ff24f53761f77

[kustermann, 2017-08-23 10:56:27]

Description was changed from

==========
Disable --deoptimize-every/--stacktrace-every in kernel isolate

Fixes https://github.com/dart-lang/sdk/issues/28788
Fixes https://github.com/dart-lang/sdk/issues/28933
==========

to

==========
Disable --deoptimize-every/--stacktrace-every in kernel isolate

Since the kernel isolate is just an auxiliary service, it makes little sense
that it "inherit" these flag (similarly --checked is not "inherited" by kernel
isolate)

Fixes https://github.com/dart-lang/sdk/issues/28788
Fixes https://github.com/dart-lang/sdk/issues/28933
==========

[kustermann, 2017-08-23 10:56:59]

Description was changed from

==========
Disable --deoptimize-every/--stacktrace-every in kernel isolate

Since the kernel isolate is just an auxiliary service, it makes little sense
that it "inherit" these flag (similarly --checked is not "inherited" by kernel
isolate)

Fixes https://github.com/dart-lang/sdk/issues/28788
Fixes https://github.com/dart-lang/sdk/issues/28933
==========

to

==========
[VM] Disable --deoptimize-every/--stacktrace-every in kernel isolate

Since the kernel isolate is just an auxiliary service, it makes little sense
that it "inherit" these flag (similarly --checked is not "inherited" by kernel
isolate)

Fixes https://github.com/dart-lang/sdk/issues/28788
Fixes https://github.com/dart-lang/sdk/issues/28933
==========

[kustermann, 2017-08-23 10:57:21]

kustermann@google.com changed reviewers:
+ asiva@google.com

[kustermann, 2017-08-23 11:22:14]

kustermann@google.com changed reviewers:
+ vegorov@google.com

[kustermann, 2017-08-23 11:22:15]

https://codereview.chromium.org/2997403002/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/2997403002/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:305: #if defined(DART_PRECOMPILED_RUNTIME)
Does someone know why the other FlowGraphCompiler code would be included in
DART_PRECOMPILED_RUNTIME?

[Vyacheslav Egorov (Google), 2017-08-23 18:41:25]

lgtm

https://codereview.chromium.org/2997403002/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/2997403002/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:305: #if defined(DART_PRECOMPILED_RUNTIME)
On 2017/08/23 11:22:15, kustermann wrote:
> Does someone know why the other FlowGraphCompiler code would be included in
> DART_PRECOMPILED_RUNTIME?

I think it's just compiled and should be thrown by a linker. 

Aske's change does a proper coarse grained ifdef-ing, but that got reverted.

https://codereview.chromium.org/2997403002/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:311: const bool is_kernel_isolate =
KernelIsolate::IsKernelIsolate(isolate());
What about VMService isolate?

[kustermann, 2017-08-24 09:13:40]

Patchset #3 (id:40001) has been deleted

[kustermann, 2017-08-24 09:15:02]

https://codereview.chromium.org/2997403002/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/2997403002/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:305: #if defined(DART_PRECOMPILED_RUNTIME)
On 2017/08/23 18:41:25, Vyacheslav Egorov (Google) wrote:
> On 2017/08/23 11:22:15, kustermann wrote:
> > Does someone know why the other FlowGraphCompiler code would be included in
> > DART_PRECOMPILED_RUNTIME?
> 
> I think it's just compiled and should be thrown by a linker. 
> 
> Aske's change does a proper coarse grained ifdef-ing, but that got reverted.

Makes sense.

https://codereview.chromium.org/2997403002/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:311: const bool is_kernel_isolate =
KernelIsolate::IsKernelIsolate(isolate());
On 2017/08/23 18:41:25, Vyacheslav Egorov (Google) wrote:
> What about VMService isolate?

done

[kustermann, 2017-08-24 09:15:22]

Description was changed from

==========
[VM] Disable --deoptimize-every/--stacktrace-every in kernel isolate

Since the kernel isolate is just an auxiliary service, it makes little sense
that it "inherit" these flag (similarly --checked is not "inherited" by kernel
isolate)

Fixes https://github.com/dart-lang/sdk/issues/28788
Fixes https://github.com/dart-lang/sdk/issues/28933
==========

to

==========
[VM] Disable --deoptimize-every/--stacktrace-every in kernel isolate

Since the kernel isolate is just an auxiliary service, it makes little sense
that it "inherit" these flag (similarly --checked is not "inherited" by kernel
isolate)

Fixes https://github.com/dart-lang/sdk/issues/28788
Fixes https://github.com/dart-lang/sdk/issues/28933

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/055dbbfd68235965c35e1101771ff24f53761f77
==========

[kustermann, 2017-08-24 09:15:23]

Committed patchset #3 (id:60001) manually as
055dbbfd68235965c35e1101771ff24f53761f77 (presubmit successful).